Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-30 Thread Keith Packard
Emil Velikov writes: > Amazing. On behalf of anyone who has to deal with the Windows side of > things - thank you. I'd love to see this working on Windows -- I think it could use either WSAPoll or select; neither of those depend on FD values at all. > Side note:

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-30 Thread Emil Velikov
On 30 May 2016 at 08:47, Keith Packard wrote: > Julien Cristau writes: > >>> #define X_NOTIFY_READ POLLIN >>> #define X_NOTIFY_WRITE POLLOUT >>> #define X_NOTIFY_OTHER (!(POLLIN|POLLOUT)) >>> >> I guess you mean ~(POLLIN|POLLOUT). > > Yes, thanks. I've

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-30 Thread Keith Packard
Julien Cristau writes: >> #define X_NOTIFY_READ POLLIN >> #define X_NOTIFY_WRITE POLLOUT >> #define X_NOTIFY_OTHER (!(POLLIN|POLLOUT)) >> > I guess you mean ~(POLLIN|POLLOUT). Yes, thanks. I've actually reconsidered and decided to make an interface which doesn't use

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-30 Thread Julien Cristau
On Sun, May 29, 2016 at 11:35:16 -0700, Keith Packard wrote: > Emil Velikov writes: > > > There's two things which I should have mentioned: > > - How does one have poll.h when poll() is missing - Cygwin may have > > the header, although I'm not sure about other

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-29 Thread Keith Packard
Emil Velikov writes: > There's two things which I should have mentioned: > - How does one have poll.h when poll() is missing - Cygwin may have > the header, although I'm not sure about other Windows based > implementations (the mingw and msvc ones). I'd expect

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-29 Thread Emil Velikov
On 28 May 2016 at 02:53, Keith Packard wrote: > Emil Velikov writes: > >> Hi Keith, >> >> Style question: do you/how many others refer having separate functions for >> of ifdeffed code each vs a single with all the ifdeffs. Or in other words >> having

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-27 Thread Keith Packard
Emil Velikov writes: > Hi Keith, > > Style question: do you/how many others refer having separate functions for > of ifdeffed code each vs a single with all the ifdeffs. Or in other words > having func_foo_poll and func_foo_epoll as opposed to having it all in >

Re: [PATCH xserver 17/23] os: Add ospoll interface

2016-05-27 Thread Emil Velikov
Hi Keith, Style question: do you/how many others refer having separate functions for of ifdeffed code each vs a single with all the ifdeffs. Or in other words having func_foo_poll and func_foo_epoll as opposed to having it all in func_foo. On Friday, 27 May 2016, Keith Packard

[PATCH xserver 17/23] os: Add ospoll interface

2016-05-26 Thread Keith Packard
This provides a wrapper around poll, epoll or WSAPoll providing a callback-based interface for monitoring activity on a large set of file descriptors. Signed-off-by: Keith Packard --- configure.ac| 2 +- include/dix-config.h.in | 9 + os/Makefile.am |