[PATCH xf86-video-vmware] Fix include order.

2011-01-21 Thread Cyril Brulebois
of function ‘drmOpen’ | vmwaremodule.c:112: error: implicit declaration of function ‘drmClose’ Signed-off-by: Cyril Brulebois k...@debian.org --- src/vmwaremodule.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vmwaremodule.c b/src/vmwaremodule.c index a7ba854

Re: [PATCH (v5) inputproto 1/1] Add touch classes and events, bump to 2.1

2011-01-23 Thread Cyril Brulebois
Daniel Stone dan...@fooishbar.org (19/01/2011): @@ -1526,6 +1776,20 @@ EVENTHEADER { type: BYTE KeyRepeat means that this event is for repeating purposes, and the physical state of the key has not changed. This is only valid for KeyPress

Re: [PATCH (v5) xserver 7/8] Input: Add initial multitouch support from Xi 2.1

2011-01-23 Thread Cyril Brulebois
Hi Daniel, Daniel Stone dan...@fooishbar.org (19/01/2011): --- a/dix/getevents.c +++ b/dix/getevents.c […] +int +GetTouchEvents(EventList *events, DeviceIntPtr pDev, TouchPointInfoPtr ti, + uint16_t type, uint32_t flags, const ValuatorMask *mask_in) +{ […] +

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Cyril Brulebois
Daniel Stone dan...@fooishbar.org (19/01/2011): From: Chase Douglas chase.doug...@canonical.com This multitouch addition only supports slotted MT evdev protocol devices. Support must be enabled at configure time using --enable-multitouch. Signed-off-by: Chase Douglas

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Cyril Brulebois
Cyril Brulebois k...@debian.org (24/01/2011): Need to check the xi minor version in the server as well: | evdev.c: In function ‘EvdevPostQueuedEvents’: | evdev.c:862: warning: implicit declaration of function ‘xf86PostTouchEvent’ | evdev.c:862: warning: nested extern declaration

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Cyril Brulebois
Daniel Stone dan...@fooishbar.org (19/01/2011): +#ifdef MULTITOUCH +free(pEvdev-mtMask); +pEvdev-mtMask = NULL; +for (i = 0; i EVDEV_MAXQUEUE; i++) +free(pEvdev-queue[i].touchMask); +pEvdev-queue[i].touchMask = NULL; +#endif Missing {} here. [Thank you, gcc!

Re: [PATCH (v5) 0/15] Multitouch take five

2011-01-23 Thread Cyril Brulebois
Daniel Stone dan...@fooishbar.org (19/01/2011): Another round of multitouch patches ... this lot addresses all the review comments from the previous patchset, and seems to work quite reliably and consistently for me. It's a fairly large change, but the code is now a fair bit easier to

[PATCH] Add prototype for CheckDefaultMap().

2011-01-28 Thread Cyril Brulebois
: warning: nested extern declaration of ‘CheckDefaultMap’ Signed-off-by: Cyril Brulebois k...@debian.org --- src/xkbcomp/parseutils.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/xkbcomp/parseutils.h b/src/xkbcomp/parseutils.h index 9cf5097..c0a78df 100644 --- a/src

Re: [PATCH libxkbcommon] Add prototype for CheckDefaultMap().

2011-01-28 Thread Cyril Brulebois
Cyril Brulebois k...@debian.org (28/01/2011): Those warnings disappear accordingly: | CC parseutils.lo | parseutils.c:742: warning: no previous prototype for ‘CheckDefaultMap’ | CC xkbscan.lo | xkbscan.l: In function ‘XKBParseString’: | xkbscan.l:220: warning: implicit

[PATCH libxkbcommon] Check for x11 as well through pkg-config.

2011-01-28 Thread Cyril Brulebois
Otherwise, ./configure returns successfully while xkbparse.lo can fail to build due to a missing include: | YACC xkbparse.c | CC xkbparse.lo | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory Signed-off-by: Cyril Brulebois k...@debian.org --- configure.ac |2 +- 1

Re: [PATCH libxkbcommon] Check for x11 as well through pkg-config.

2011-01-29 Thread Cyril Brulebois
Gaetan Nadon mems...@videotron.ca (29/01/2011): I recall some readings putting emphasis on the fact that the library did not depend on libX11. […] Maybe this include is not necessary or there is an alternate solution to not depend on X11. Ooh, thanks. This include indeed seems extraneous,

[PATCH libxkbcommon] Get rid of unneeded X11/Xlib.h include.

2011-01-29 Thread Cyril Brulebois
There's no need for this xlib include: | YACC xkbparse.c | CC xkbparse.lo | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory Signed-off-by: Cyril Brulebois k...@debian.org --- src/xkbcomp/xkbparse.y |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

xorg-server/*bsd: moving from hal support to devd support?

2011-02-13 Thread Cyril Brulebois
Hi FreeBSD/X11 folks, as an occasional GNU/kFreeBSD porter, I've been wondering what's going to happen with hal going away/being unmaintained. I've been pointed to a blog post about Xfce on *BSD [1], where it is mentioned that devd might be used as a udev equivalent. 1.

Re: xorg-server/*bsd: moving from hal support to devd support?

2011-02-13 Thread Cyril Brulebois
Hi Dan, Dan Nicholson dbn.li...@gmail.com (13/02/2011): As someone who's worked on the udev backend for input devices, what needs to be provided is pretty simple. thanks! 1. X needs to know about devices that are already plugged in when the server starts I haven't looked yet, but probably

Re: xorg-server/*bsd: moving from hal support to devd support?

2011-02-15 Thread Cyril Brulebois
Hi Warner, Warner Losh i...@bsdimp.com (14/02/2011): I'm mentioned this several times now: Get me a spec for what Linux udev provides, and what services are needed, and I'll make a compatible implementation on FreeBSD. as far as X is concerned, see Dan's reply to my first mail:

Re: Current tinderbox regression (xserver, randr)

2011-02-18 Thread Cyril Brulebois
Chris Ball c...@laptop.org (17/02/2011): http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build rrcrtc.c: In function 'RRConvertCrtcConfig': rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first use in this function) rrcrtc.c:1512: error: (Each undeclared identifier

[PATCH libFS] Silence gcc warning.

2011-02-18 Thread Cyril Brulebois
to be sufficient for this buffer's size… Signed-off-by: Cyril Brulebois k...@debian.org --- test/FSGetErrorText.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/FSGetErrorText.c b/test/FSGetErrorText.c index 31523c6..f9a88d2 100644 --- a/test/FSGetErrorText.c +++ b/test

Input drivers (was [ANNOUNCE] xorg-server 1.9.99.902 (1.10 RC2))

2011-02-19 Thread Cyril Brulebois
Hi, Keith Packard kei...@keithp.com (18/02/2011): Other than that, I think we're pretty much ready for the 1.10 release. Let me know if you've got pending fixes that you want to see merged in 1.10. Peter, could we please get a (pre)release for -synaptics? Latest release doesn't build with

[PATCH] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

2011-02-20 Thread Cyril Brulebois
Fix typo introduced in: 3a9bb93dd178084f4ff1abcea331ca5a62f88ce6 Signed-off-by: Cyril Brulebois k...@debian.org --- hw/xfree86/common/xf86sbusBus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) BIG FAT WARNING: Not actually tested yet. Waiting for other builds to finish before

Fixing out-of-tree failures in hw/dmx/doc

2011-02-20 Thread Cyril Brulebois
Hi, I saw Dan's reply, but I'm posting anyway the tiny patch series that fixes the out-of-tree build for me (with devel docs enabled, with doxygen; not tried distcheck). [PATCH 1/3] hw/dmx/doc: Fix missing slash in css target. Trivial enough. [PATCH 2/3] hw/dmx/doc: Specify {src,build}dir in

[PATCH 3/3] hw/dmx/doc: Move from $(builddir) to $(abs_builddir).

2011-02-20 Thread Cyril Brulebois
$(builddir)/doxygen.* targets are never considered out-of-date, so symlinks never get created and out-of-tree builds fail. Using $(abs_builddir) instead fixes it. Signed-off-by: Cyril Brulebois k...@debian.org --- hw/dmx/doc/Makefile.am |8 1 files changed, 4 insertions(+), 4

[PATCH 1/3] hw/dmx/doc: Fix missing slash in css target.

2011-02-20 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- hw/dmx/doc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx/doc/Makefile.am b/hw/dmx/doc/Makefile.am index 4bbc8bf..17defb5 100644 --- a/hw/dmx/doc/Makefile.am +++ b/hw/dmx/doc/Makefile.am @@ -260,6

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-20 Thread Cyril Brulebois
Nicholson dbn.li...@gmail.com Tested-by: Cyril Brulebois k...@debian.org both in-tree and out-of-tree. Thanks. KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH mouse 1/6] man: remove mention of core pointer.

2011-02-20 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/02/2011): This doesn't apply to X servers 1.7 and later. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net For the series: Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011-02-24 Thread Cyril Brulebois
drmmode_xf86crtc_resize hook, fixes https://bugs.freedesktop.org/show_bug.cgi?id=33929 . On the other hand, the system memory copy doesn't need the pitch to be aligned beyond the PixmapBytePad of the width. Signed-off-by: Michel Dänzer daen...@vmware.com Yay! Acked-by: Cyril Brulebois k

[PULL] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

2011-02-24 Thread Cyril Brulebois
Hi Keith, Cyril Brulebois k...@debian.org (20/02/2011): BIG FAT WARNING: Not actually tested yet. Waiting for other builds to finish before uploading a new revision with that fix. no longer true, the build went fine until the unit tests. Keith, please pull from: git://git.debian.org/users

Re: [PATCH] randr: Add 'set' fields to SetCrtcConfigs request

2011-02-24 Thread Cyril Brulebois
Hi, Keith Packard kei...@keithp.com (24/02/2011): As release manager, this seems like the right solution. However, it's a larger change than adding the new fix-ups, which doesn't exactly make me less nervous. not that I'm advocating last-minute pushes, I gave it a try anyway. If you want to

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011-02-24 Thread Cyril Brulebois
Keith Packard kei...@keithp.com (24/02/2011): On Thu, 24 Feb 2011 12:17:57 +0100, Michel Dänzer mic...@daenzer.net wrote: On the other hand, the system memory copy doesn't need the pitch to be aligned beyond the PixmapBytePad of the width. Merged. Hi Jeremy, please consider

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-24 Thread Cyril Brulebois
Hi Dan, Dan Nicholson dbn.li...@gmail.com (20/02/2011): The paths in doxygen.conf assumed that srcdir=builddir and broke otherwise. Use autoconf to fill in the paths to the srcdir so that the files can be found when users have a separate build directory (as with distcheck). Signed-off-by:

Re: [PULL] Server build fixes

2011-02-25 Thread Cyril Brulebois
Keith Packard kei...@keithp.com (25/02/2011): So, I'm a bit confused here -- I do 'make distcheck' to build releases, and it works for me. I'd like to know how I can test this patch to make sure it does what you expect. Do you end up building with devel docs, so with doxygen support when

[PATCH xf86-video-vmware] Remove unused variable.

2011-02-26 Thread Cyril Brulebois
Fix the build with CFLAGS=-Wall -Werror: | CC vmware_drv_la-vmwaremodule.lo | cc1: warnings being treated as errors | vmwaremodule.c: In function ‘vmware_chain_module’: | vmwaremodule.c:178: error: unused variable ‘ret’ Signed-off-by: Cyril Brulebois k...@debian.org --- src/vmwaremodule.c

Re: [PULL] Server build fixes

2011-02-26 Thread Cyril Brulebois
Dan Nicholson dbn.li...@gmail.com (26/02/2011): And when I run make, sdksyms.sh is run first and then sdksyms.c is built. Can you check if that's the case on your error? Or, if you manually run sdksyms.sh again, does the error go away? You may be right, though. sdksyms.c doesn't explicitly

Re: [PULL] Server build fixes

2011-02-26 Thread Cyril Brulebois
patch → works. Accordingly: Tested-by: Cyril Brulebois k...@debian.org Also, the generated sdksyms.c lands in the build directory, meaning one can happily do stuff like: mkdir build1 build2 (cd build1 ../configure --disable-stuff) (cd build2 ../configure --enable-stuff) make -C build1

[PATCH] xf86AutoConfig: Try newport on mips.

2011-02-27 Thread Cyril Brulebois
As suggested by Bernhard R. Link in Debian bug report #566545 (http://bugs.debian.org/566545), newport is a candidate for autodetection on mips. Signed-off-by: Cyril Brulebois k...@debian.org --- hw/xfree86/common/xf86AutoConfig.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-02-27 Thread Cyril Brulebois
Hi, Mark Kettenis mark.kette...@xs4all.nl (27/02/2011): Not necessary a good idea. The autoconfig code was broken some time ago by a all-the-world-is-PCI believer some time ago. The breakage is that if you list more than a single possible video driver, things break. That's why we actually

[PATCH] Xephyr: Mention Xserver's options are also accepted.

2011-02-27 Thread Cyril Brulebois
Originally reported in the Debian BTS: http://bugs.debian.org/582650 Signed-off-by: Jari Aalto jari.aa...@cante.net Signed-off-by: Cyril Brulebois k...@debian.org --- hw/kdrive/ephyr/man/Xephyr.man |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Apparently already rb'd by Alan

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-02-27 Thread Cyril Brulebois
Matt Turner matts...@gmail.com (28/02/2011): Since newport doesn't even compile anymore (since the RAC removal), this probably isn't helpful at all. Ah. At the moment I haven't rebuilt all drivers against 1.10 (only against 1.9.x for now), so I didn't notice that. Sorry for the noise then.

Re: 1.11 release process (was: [PULL] -next branch for 1.11)

2011-03-01 Thread Cyril Brulebois
Hi, Jeremy Huddleston jerem...@apple.com (01/03/2011): I think that locked-step changes should be done as simultaneously as possible. We should try not to merge proto updates that cause the server to stop building (as was the case with randr for a while) until both sets are reviewed and can

[PATCH xf86-video-nv] Fix compiler warning.

2011-03-01 Thread Cyril Brulebois
Get rid of this with CFLAGS=-Wall -Werror: | CC g80_display.lo | cc1: warnings being treated as errors | g80_display.c: In function ‘G80CrtcSetPClk’: | g80_display.c:216: error: unused variable ‘i’ Signed-off-by: Cyril Brulebois k...@debian.org --- src/g80_display.c |2 +- 1 files

[PATCH:xinit] Fix minor typos in startx's comments.

2011-03-05 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- startx.cpp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/startx.cpp b/startx.cpp index f055ad9..0f4cca5 100644 --- a/startx.cpp +++ b/startx.cpp @@ -5,8 +5,8 @@ XCOMM This is just a sample implementation

Re: [PATCH] XDM: Fix missing linking dependency on -ldl.

2011-03-05 Thread Cyril Brulebois
not about introducing a “new” DSO linker. Reviewed-by: Gaetan Nadon mems...@videotron.ca If we're going to go the AC_SEARCH_LIBS way, I guess it's time to apply that patch, and time for me to submit some other similar patches for similar bugs we have in the Debian BTS: Reviewed-by: Cyril Brulebois k

Re: [PATCH modular] jhbuild: Mark xf86-video-sunbw2 as unmaintained.

2011-03-06 Thread Cyril Brulebois
Hi, Dan Nicholson dbn.li...@gmail.com (06/03/2011): I've been playing with jhbuild more lately and had made the change locally. The only difference is I also removed it from the xorg-sun-drivers metamodule since I figure if you want to build the sun drivers, you still don't want this broken

Re: [PATCH modular 1/3 (v2)] jhbuild: Pass --enable-nouveau-experimental-api to libdrm.

2011-03-06 Thread Cyril Brulebois
Hi, Dan Nicholson dbn.li...@gmail.com (06/03/2011): Would this be more appropriate to put in the module definition so that we don't have to depend on people's jhbuildrc? looks far better (didn't check it myself though), please go ahead if that just works. KiBi. signature.asc Description:

Re: [PATCH modular 2/3 (v3)] jhbuild: Support skipping packages on a per-architecture basis.

2011-03-06 Thread Cyril Brulebois
Hi again, Dan Nicholson dbn.li...@gmail.com (06/03/2011): Now that I've spent some more time with jhbuild, I have some comments that I'd like to get your feedback on. Sorry this is so long after the 3(!) previous reviews. unfortunately, I might need some time to look into it, I'm not sure I

Re: [PATCH modular 3/3] jhbuild: Add makedepend, needed for mesa.

2011-03-06 Thread Cyril Brulebois
Dan Nicholson dbn.li...@gmail.com (06/03/2011): Reviewing these patches again... Thanks.. Here the dependency is being added to libdrm instead of libGL. Is that intentional? I don't think so, got confused by the mesa/* namespace or so I guess. KiBi. signature.asc Description: Digital

[PATCH 2/2] os: Work around integer overflow in TimerSet.

2011-03-06 Thread Cyril Brulebois
://bugs.debian.org/616667 X.Org Bug 35066 http://bugs.freedesktop.org/show_bug.cgi?id=35066 Signed-off-by: Cyril Brulebois k...@debian.org --- os/WaitFor.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index d44e00b..39f506e 100644 --- a/os

[PATCH 1/2] os: Fix buggy integer comparison.

2011-03-06 Thread Cyril Brulebois
integer/2). Accordingly, replace all: (int) (foo-bar) = 0 tests with: foo = bar This is the first patch to fix the following bugs. Debian Bug 616667 http://bugs.debian.org/616667 X.Org Bug 35066 http://bugs.freedesktop.org/show_bug.cgi?id=35066 Signed-off-by: Cyril Brulebois k...@debian.org

Re: [PATCH 2/2] os: Work around integer overflow in TimerSet.

2011-03-06 Thread Cyril Brulebois
Hi, Fernando Carrijo fcarr...@freedesktop.org (06/03/2011): I found this, buried in Section 6.2.5 (9) of the C Standard: A computation involving unsigned operands can never overflow, because a result that cannot be represented by the resulting unsigned integer type is reduced

Re: [PATCH synaptics] Remove unused test directory (#35043)

2011-03-06 Thread Cyril Brulebois
-pad.c delete mode 100644 test/testprotocol.c Thanks. Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH 1/2] os: Fix buggy integer comparison.

2011-03-07 Thread Cyril Brulebois
Keith Packard kei...@keithp.com (06/03/2011): […] We want the former result, not the latter. Unless being pointed to the appropriate stuff from 2002 by Alan (thanks!), what we want isn't exactly clear while going through the code. Might deserve some comments, maybe? That was already reported

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-07 Thread Cyril Brulebois
Hi Alan, Alan Coopersmith alan.coopersm...@oracle.com (12/01/2011): Now that we don't need to separately strlen the format string, put it directly into the function call to clear gcc warnings of: Initialize.c:397: warning: format not a string literal, argument types not checked

[PATCH] Xext: relax assert in SecurityAuthorizationExpired.

2011-03-07 Thread Cyril Brulebois
in xauth calls, and would make the server abort. Debian Bug #616667 http://bugs.debian.org/616667 X.Org Bug #27134 http://bugs.freedesktop.org/show_bug.cgi?id=27134 X.Org Bug #35066 http://bugs.freedesktop.org/show_bug.cgi?id=35066 Signed-off-by: Cyril Brulebois k...@debian.org --- Xext/security.c

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-08 Thread Cyril Brulebois
Alan Coopersmith alan.coopersm...@oracle.com (07/03/2011): Perhaps a difference in the setting of $HOME or one of the other environment variables that GetRootDirName checks for the homedir? Indeed, '/' when starting from init, '/root' when starting later as root. I tried unsetting a few

[libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-08 Thread Cyril Brulebois
Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. Debian Bug #617208 http://bugs.debian.org/617208 Signed-off-by: Cyril Brulebois k...@debian.org --- src/Alloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Cyril Brulebois
Alan Coopersmith alan.coopersm...@oracle.com (08/03/2011): Simple test case just compares the results of snprintf to a static buffer with the new buffer returned by XtAsprintf. Good idea. I think you should also have another test, with a bigger string to hit the second code path (the vsnprintf

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Cyril Brulebois
Gaetan Nadon mems...@videotron.ca (08/03/2011): Tests are only executed when running make check, is the --enable-unit-tests really needed? I could understand why people wouldn't want glib to be pulled in unconditionally when building libxt. As a package maintainer, I'm happy to declare through

Re: [PATCH v2:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-10 Thread Cyril Brulebois
Alan Coopersmith alan.coopersm...@oracle.com (09/03/2011): Only two simple test cases to start with: v2: Thanks to suggestions from many on #xorg-devel IRC, set malloc debugging environment variables for common platforms (only tested on Solaris though) Hitting 100/0 OK/NOK with it. Once

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

2011-03-15 Thread Cyril Brulebois
vmmouse +driver will be ignored. Regardless of the above comment: Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH] Xext: relax assert in SecurityAuthorizationExpired.

2011-03-15 Thread Cyril Brulebois
Cyril Brulebois k...@debian.org (07/03/2011): The following code path is considered valid: SecurityAuthorizationExpired TimerSet SecurityStartAuthorizationTimer In other words, SecurityAuthorizationExpired can be called while pAuth-timer is still NULL, so relax the assert

Re: [PATCH xserver 2/3] Add generalized unit test support using util-macros.

2011-03-18 Thread Cyril Brulebois
. than Thanks for your work on unit tests, for the series: Acked-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH xserver 2/3] Add generalized unit test support using util-macros.

2011-03-18 Thread Cyril Brulebois
be used by itself in contexts other then unit testing. than Thanks for your work on unit tests, for the series: Acked-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org

Re: [PATCH] dri: kill if 0 out code.

2011-03-24 Thread Cyril Brulebois
Dave Airlie airl...@gmail.com (24/03/2011): From: Dave Airlie airl...@redhat.com This refers to pWin-winSize in some #if 0 code remove it. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature

Re: [PATCH] xfree86: print out which driver is about to be used.

2011-03-24 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (18/03/2011): Makes reading the log file a lot easier for those that don't magically recognise the log spew by the individual drivers. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Oh yeah. Reviewed-by: Cyril Brulebois k...@debian.org KiBi

Re: [PATCH synaptics 09/17] eventcomm: print an error when axis range failed.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Judging by a quick google search, this isn't a common error that the user will see, it's a bug. So print out information useful for those triaging/debugging. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril

Re: [PATCH synaptics 01/17] eventcomm: add a missing break statement

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): If the EV_SYN wasn't SYN_REPORT, we'd fall through to key event processing, which almost certainly won't do what we want and/or need. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org

Re: [PATCH synaptics 02/17] eventcomm: factor out finger counting.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): one, two, three, many. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel

Re: [PATCH synaptics 03/17] eventcomm: extern EventReadHwState to allow for testing.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH synaptics 04/17] eventcomm: replace synaptics-custom TEST_BIT with server's BitIsOn.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH synaptics 05/17] eventcomm: rename parameter name grab to test_grab

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): We don't permanently grab the device here, we just check whether a grab is possible. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature

Re: [PATCH synaptics 06/17] eventcomm: document event_query_is_touchpad

2011-03-25 Thread Cyril Brulebois
“as a touchpad device”. Not that I'm a native speaker anyway. With or without it: Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH synaptics 12/17] eventcomm: fix indentation in EventAutoDevProbe

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Cyril Brulebois
: dixRegisterPrivateKey(exaScreenPrivateKeyRec, PRIVATE_SCREEN, 0) #define exaScreenPrivateKey (exaScreenPrivateKeyRec) and others with sizeof() instead… it looks like we're indeed in the right branch of dixLookupPrivate()'s if() in all cases, so that looks fine. Reviewed-by: Cyril Brulebois k...@debian.org

Re: [PATCH 1/2] Clean up getValuatorEvents with token concatenation

2011-03-29 Thread Cyril Brulebois
Hi, Chase Douglas chase.doug...@canonical.com (28/03/2011): +#define set_valuator_value(xv, ev, num) \ +xv-valuator##num = (ev)-valuators.data[(xv)-first_valuator + num]; I guess (for consistency at least) you could be using (xv)→… at the beginning, or maybe even put () around all

Re: [ANNOUNCE] xorg-sgml-doctools 1.7

2011-03-30 Thread Cyril Brulebois
Hi Gaetan, Gaetan Nadon mems...@videotron.ca (29/03/2011): Gaetan Nadon (3): config: comment, minor upgrade, quote and layout configure.ac DocBook/XML: add support for docbook external references Version bump: 1.7 building an updated package, a few new files come up, which

Re: [ANNOUNCE] xorg-sgml-doctools 1.7

2011-03-30 Thread Cyril Brulebois
Gaetan Nadon mems...@videotron.ca (30/03/2011): Both of these are new files, replacing xorg.xsl […] This is correct. There has to be one master db per format. It points to a real filename such as secint.html, secint.pdf, etc... Thanks for confirming. For example, gnome-help can read

[PATCH 2/9] Xrandr.man: Fix grammar.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index df585d1..fea196a 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -121,7 +121,7 @@ Specifies which screen. .IP

[PATCH 4/9] Xrandr.man: Try to make some sense.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 0124181..8aa572a 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -224,7 +224,7 @@ Randr, the coordinate system

[PATCH 3/9] Xrandr.man: Build full sentences, possibly easier to read.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index fea196a..0124181 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -178,14 +178,17 @@ typedef struct

Try to make Xrandr's manpage a bit easier on the eyes

2011-03-30 Thread Cyril Brulebois
Hi, here are some patches I came up with while I was playing around with some XRR* functions. *BIG FAT WARNING*: I'm not a native speaker, or writer. All in all, shouldn't be too hard to review, since it's only about: | man/Xrandr.man | 81

[PATCH 1/9] Xrandr.man: Remove trailing spaces.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 23a3970..df585d1 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man

[PATCH 5/9] Xrandr.man: Fix typo.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 8aa572a..36905cc 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -275,7 +275,7 @@ of the server. If RandR

[PATCH 6/9] Xrandr.man: Build full sentences for easier reading.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 36905cc..14dcb51 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -308,9 +308,9 @@ information if it fails

[PATCH 7/9] Xrandr.man: Fix missing closing parenthesis.

2011-03-30 Thread Cyril Brulebois
Also fix the closing tag (\fP instead of \fI). Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 14dcb51..75481fa 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man

[PATCH 9/9] Xrandr.man: Document how to request notifications.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index bcb8a47..f7c0088 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -185,7 +185,9 @@ structure contains a possible

[PATCH 8/9] Xrandr.man: Fix parenthesis escaping.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 75481fa..bcb8a47 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -94,7 +94,7 @@ void XRRSelectInput\^(\^Display

[libxrandr] Try to make Xrandr's manpage a bit easier on the eyes

2011-03-30 Thread Cyril Brulebois
Cyril Brulebois k...@debian.org (31/03/2011): here are some patches I came up with while I was playing around with some XRR* functions. And of course I forgot --subject-prefix, sorry for that. All of them are for libxrandr, which shouldn't be too hard to guess anyway… KiBi. signature.asc

[PATCH:libxrandr 4/9 v2] Xrandr.man: Try to make some sense.

2011-03-31 Thread Cyril Brulebois
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Magnus Kessler magnus.kess...@gmx.net Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) v2

Re: [PATCH] xf86-video-mga: fix typo in MGADRIMoveBuffersXAA()

2011-04-03 Thread Cyril Brulebois
Nicolas Kaiser ni...@nikai.net (02/04/2011): Fix typo in MGADRIMoveBuffersXAA(). Signed-off-by: Nicolas Kaiser ni...@nikai.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel

Re: [PATCH] xf86-video-mga: replace deprecated X*alloc functions

2011-04-03 Thread Cyril Brulebois
For: Nicolas Kaiser ni...@nikai.net (02/04/2011): - if (pptNew2) xfree(pptNew2); - if (pboxNew2) xfree(pboxNew2); + if (pptNew2) free(pptNew2); + if (pboxNew2) free(pboxNew2); and others, you may want to get rid of the if(), free() can handle

Re: multitouch and synaptics clickpad status

2011-04-04 Thread Cyril Brulebois
Henrik Rydberg rydb...@euromail.se (04/04/2011): The xf86-input-multitouch driver is not yet part of any distro, but that is likely to change within the coming six months. kibi@caol-ila:~$ rmadison xf86-input-multitouch xf86-input-multitouch | 1.0~rc2-2 | wheezy | source xf86-input-multitouch

Re: [RFC PATCH inputproto 3/3] Put a #warning and #error in to avoid unsuspecting XI 2.1 users.

2011-04-08 Thread Cyril Brulebois
: Reviewed-by: Cyril Brulebois k...@debian.org Also, what Daniel proposed looks like a good idea. KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH v2] linux: Retry VT ioctls while errno == EINTR

2011-04-08 Thread Cyril Brulebois
switches that actually succeed. Signed-off-by: Aaron Plattner aplatt...@nvidia.com Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: Update Latvian keyboard mapping

2011-04-10 Thread Cyril Brulebois
Hi, Aldis Berjoza al...@bsdroot.lv (10/04/2011): Yesterday I added Dvorak, Dvorak programmers and Colemak US compatible layouts to Latvian keyboard mapping. I was wondering if you'd like to import it in Xorg? I think you should be contacting this list instead: x...@listserv.bat.ru See:

[PATCH:xf86-input-synaptics] Fix egde/edge typo in manpage and comments.

2011-04-13 Thread Cyril Brulebois
Debian bug #622663 http://bugs.debian.org/622663 Signed-off-by: Cyril Brulebois k...@debian.org --- man/synaptics.man |4 ++-- src/synapticsstr.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/synaptics.man b/man/synaptics.man index 07327c5..cd80641 100644

Re: [PATCH xdm] Implement ConsoleKit support.

2011-05-04 Thread Cyril Brulebois
Hi, (just witnessed I can no longer halt or reboot my computer, and ck-list-sessions pretends it's a non-local session.) Fernando Tarlá Cardoso Lemos fernando...@gmail.com (24/02/2011): Since ConsoleKit 0.4.2, the sessions created by ck-launch-session are no longer marked as local and active.

Post-1.5.0 cleanup for xf86-input-acecad

2011-05-04 Thread Cyril Brulebois
Hi, nothing fancy, I hope. Just addressing a few compiler warnings, and following Peter's suggestion, dropping support for input ABI 12. Mraw, KiBi. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH:xf86-input-acecad 2/6] Silence gcc: report_{x, y} are getting initialized.

2011-05-04 Thread Cyril Brulebois
(with XORG_BOTCHED_INPUT or not) will lead report_x and report_y to be set, but make sure the compiler stops guessing. Signed-off-by: Cyril Brulebois k...@debian.org --- src/acecad.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/acecad.c b/src/acecad.c index f5a2213

[PATCH:xf86-input-acecad 4/6] Drop support for pre-input ABI 12 servers.

2011-05-04 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- configure.ac |2 +- src/acecad.c | 75 +++-- src/acecad.h |5 3 files changed, 5 insertions(+), 77 deletions(-) diff --git a/configure.ac b/configure.ac index 4c76754..5b11092

[PATCH:xf86-input-acecad 3/6] Fix “initialization from incompatible pointer type” for default_options.

2011-05-04 Thread Cyril Brulebois
by default] Signed-off-by: Cyril Brulebois k...@debian.org --- src/acecad.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/acecad.c b/src/acecad.c index 1e2f0c0..d60b3b6 100644 --- a/src/acecad.c +++ b/src/acecad.c @@ -106,7 +106,7 @@ /* max number of input events

[PATCH:xf86-input-acecad 5/6] Remove checks on the ABI now that 12 or higher is required.

2011-05-04 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- src/acecad.c | 22 -- 1 files changed, 0 insertions(+), 22 deletions(-) diff --git a/src/acecad.c b/src/acecad.c index 17e141f..de2577e 100644 --- a/src/acecad.c +++ b/src/acecad.c @@ -79,10 +79,8 @@ #endif #endif

  1   2   3   4   5   >