Re: [PATCH app-x11perf] config: use Autoconf rather than sed to substitute $libdir

2011-01-21 Thread Julien Cristau
On Fri, Jan 21, 2011 at 08:31:23 -0500, Gaetan Nadon wrote: The path substitution in x11perfcomp script can be done at configuration time using Autoconf. This is an alternative to using sed and requires less Makefile work. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am

Re: [PATCH 0/8] More warning fixes and build cleanups

2011-01-24 Thread Julien Cristau
On Sun, Jan 23, 2011 at 23:18:04 -0500, Adam Jackson wrote: What it says on the box. For the series, Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

[PATCH 0/3] fix regressions from glx request length checks

2011-01-27 Thread Julien Cristau
This series fixes regressions introduced in my previous glx patchset. The first two fix wrong checks, and patch 3 relaxes a few checks to work around incorrect lengths sent by mesa (I sent patches to fix those to the mesa list). glx/glxcmds.c | 31 +-- 1 files

[PATCH 2/3] glx: fix BindTexImageEXT length check

2011-01-27 Thread Julien Cristau
The request is followed by a list of attributes. X.Org bug#33449 Reported-and-tested-by: meng mengmeng.m...@intel.com Signed-off-by: Julien Cristau jcris...@debian.org --- glx/glxcmds.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/glx/glxcmds.c b/glx

[PATCH 1/3] glx: fix request length check for CreateGLXPbufferSGIX

2011-01-27 Thread Julien Cristau
The request is followed by an attribute list. Signed-off-by: Julien Cristau jcris...@debian.org --- glx/glxcmds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 3ef567d..0b375c3 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c

[PATCH 3/3] glx: Work around wrong request lengths sent by mesa

2011-01-27 Thread Julien Cristau
Reported-by: xunx.f...@intel.com Signed-off-by: Julien Cristau jcris...@debian.org --- glx/glxcmds.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 5d633df..9b4bc9e 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c @@ -1132,7

Re: [PATCH:smproxy] Explicitly depend on libICE since ICE functions are called directly

2011-01-28 Thread Julien Cristau
Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH:xlsfonts 3/3] Use _X_NORETURN from xproto 7.0.17 instead of local check

2011-01-29 Thread Julien Cristau
On Fri, Jan 28, 2011 at 20:08:52 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |5 + dsimple.h|8 +++- 2 files changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers

Re: [PATCH:xprop 1/3] inline Malloc Realloc functions

2011-01-29 Thread Julien Cristau
| 26 +++--- 3 files changed, 19 insertions(+), 33 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH:xlsfonts 2/3] inline Realloc() at the one place it's called

2011-01-29 Thread Julien Cristau
On Fri, Jan 28, 2011 at 20:08:51 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- dsimple.c | 15 --- dsimple.h |1 - xlsfonts.c |5 +++-- 3 files changed, 3 insertions(+), 18 deletions(-) Reviewed-by: Julien Cristau

Re: [PATCH:xprop 2/3] Replace Copy_String() with strdup + error check

2011-01-29 Thread Julien Cristau
On Fri, Jan 28, 2011 at 22:03:57 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- xprop.c | 25 +++-- 1 files changed, 7 insertions(+), 18 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH:xlsfonts 1/3] Remove unneeded Malloc function

2011-01-29 Thread Julien Cristau
-by: Alan Coopersmith alan.coopersm...@oracle.com --- dsimple.c | 20 +--- dsimple.h |1 - 2 files changed, 1 insertions(+), 20 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org

Re: [PATCH:xprop 3/3] Use _X_NORETURN from xproto 7.0.17 instead of local check

2011-01-29 Thread Julien Cristau
On Fri, Jan 28, 2011 at 22:03:58 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- dsimple.h|9 - 2 files changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers

Re: [PATCH libX11] config: Add an option to initialize threads by default.

2011-01-31 Thread Julien Cristau
On Mon, Jan 31, 2011 at 12:46:56 +0200, Rami Ylimäki wrote: This change makes it possible to guard a system against a missing XInitThreads call in X clients. One might argue that this is a client problem and that all X clients should call XInitThreads if it's possible that they could use Xlib

Re: [PATCH 00/25] Various fixes based on static analysis - remaining patches

2011-01-31 Thread Julien Cristau
On Mon, Jan 31, 2011 at 13:07:07 +0200, Erkki Seppälä wrote: Here are the remaining patches of the libx11 static analysis batch that have not yet received feedback from the list. Next up, pull-request :). Can you make the Subject of the patches something understandable? Having the output of

Re: [PATCH libX11] config: Add an option to initialize threads by default.

2011-01-31 Thread Julien Cristau
On Mon, Jan 31, 2011 at 15:12:29 +0200, Tiago Vignatti wrote: On 01/31/2011 01:13 PM, ext Julien Cristau wrote: On Mon, Jan 31, 2011 at 12:46:56 +0200, Rami Ylimäki wrote: This change makes it possible to guard a system against a missing XInitThreads call in X clients. One might argue

Re: [PATCH:libX11 1/2] Expand GetSizeOfFile() macro at the one place it's called

2011-02-02 Thread Julien Cristau
-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Xrm.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) For both: Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH libXmu 1/1] config: remove config test for snprintf

2011-02-02 Thread Julien Cristau
-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 17 - src/Lower.c |7 --- 2 files changed, 0 insertions(+), 24 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel

[PATCH v2 1/3] glx: fix request length check for CreateGLXPbufferSGIX

2011-02-03 Thread Julien Cristau
The request is followed by an attribute list. Signed-off-by: Julien Cristau jcris...@debian.org --- glx/glxcmds.c |2 +- glx/glxcmdsswap.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) v2: fix the swapped version diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 3ef567d

[PATCH v2 2/3] glx: fix BindTexImageEXT length check

2011-02-03 Thread Julien Cristau
The request is followed by a list of attributes. X.Org bug#33449 Reported-and-tested-by: meng mengmeng.m...@intel.com Signed-off-by: Julien Cristau jcris...@debian.org --- glx/glxcmds.c | 10 +- glx/glxcmdsswap.c |6 +- 2 files changed, 14 insertions(+), 2 deletions(-) v2

[PATCH v3 3/3] glx: Work around wrong request lengths sent by mesa

2011-02-03 Thread Julien Cristau
Reported-by: xunx.f...@intel.com Signed-off-by: Julien Cristau jcris...@debian.org --- glx/glxcmds.c | 19 +++ glx/glxcmdsswap.c | 12 +++- 2 files changed, 22 insertions(+), 9 deletions(-) v2: also handle swapped versions diff --git a/glx/glxcmds.c b/glx/glxcmds.c

Re: [PATCH libX11] poll_for_response: Really handle xcb_poll_for_reply getting a reply.

2011-02-06 Thread Julien Cristau
On Tue, Feb 1, 2011 at 13:15:04 +0200, Pauli Nieminen wrote: On Sat, Jan 29, 2011 at 8:16 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: I don't know how many distros are still shipping 1.3.x versions and not yet moving to 1.4.x, to make a new 1.3.x release worthwhile.   I

Re: [PATCH 0/3] fix regressions from glx request length checks

2011-02-09 Thread Julien Cristau
On Thu, Jan 27, 2011 at 10:32:06 +0100, Julien Cristau wrote: This series fixes regressions introduced in my previous glx patchset. The first two fix wrong checks, and patch 3 relaxes a few checks to work around incorrect lengths sent by mesa (I sent patches to fix those to the mesa list

Re: [PATCH:libFS] Off-by-one error in FSGetErrorText bounds check

2011-02-12 Thread Julien Cristau
-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:xorg-docs] MAINTAINERS: Update status of various libraries

2011-02-12 Thread Julien Cristau
On Fri, Feb 11, 2011 at 11:30:24 -0800, Alan Coopersmith wrote: Xt Xtst Xv XvMC Xxf86dga Xxf86misc +S: Unmaintained xf86misc could probably be marked as obsolete. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives:

[xkbcomp PATCH] Inline the oiText macro in the only place it's used

2011-02-13 Thread Julien Cristau
Gets rid of a compiler warning: geometry.c: In function 'HandleOverlayDef': geometry.c:2578: warning: the address of 'ol' will always evaluate as 'true' X.Org bug#34219 https://bugs.freedesktop.org/show_bug.cgi?id=34219 Signed-off-by: Julien Cristau jcris...@debian.org --- geometry.c |4

Re: [PATCH 1/2] Fix memory leak in mode validation

2011-02-14 Thread Julien Cristau
); if (ret == MODE_OK) break; Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] Be forgiving of character-cell size mismatches in mode sizes

2011-02-14 Thread Julien Cristau
On Mon, Feb 14, 2011 at 12:45:35 -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 0/3] fix regressions from glx request length checks

2011-02-14 Thread Julien Cristau
On Wed, Feb 9, 2011 at 11:08:27 +0100, Julien Cristau wrote: On Thu, Jan 27, 2011 at 10:32:06 +0100, Julien Cristau wrote: This series fixes regressions introduced in my previous glx patchset. The first two fix wrong checks, and patch 3 relaxes a few checks to work around incorrect

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Julien Cristau
On Mon, Feb 14, 2011 at 20:05:45 +0200, Oliver McFadden wrote: On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote: I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too), so I've added my Reviewed-by below. Good catch! Sorry for the

[pull] glx regression fixes

2011-02-15 Thread Julien Cristau
Hi Keith, These should be in 1.10. The following changes since commit ea1ffd3e60bdcedbec5a6f28929f8677bf45d450: Merge remote branch 'whot/for-keith' (2011-02-02 15:19:55 -0800) are available in the git repository at: git://people.freedesktop.org/~jcristau/xserver for-keith Julien Cristau

Re: [PATCH setxkbmap] man: multiple layouts can be specified (#34118)

2011-02-18 Thread Julien Cristau
On Fri, Feb 18, 2011 at 13:17:00 +1000, Peter Hutterer wrote: X.Org Bug 34118 http://bugs.freedesktop.org/show_bug.cgi?id=34118 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/setxkbmap.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH libFS] Silence gcc warning.

2011-02-19 Thread Julien Cristau
On Fri, Feb 18, 2011 at 21:17:12 +0100, Cyril Brulebois wrote: Fix the build with CFLAGS=-Wall -Werror: | CC FSGetErrorText.o | cc1: warnings being treated as errors | FSGetErrorText.c: In function ‘CheckErrorMessage’: | FSGetErrorText.c:43: error: format ‘%d’ expects type ‘int’, but

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-19 Thread Julien Cristau
On Mon, Jan 3, 2011 at 14:06:37 +, Daniel Stone wrote: Hi, So, the DMX doc stuff breaks distcheck quite badly. If I have --disable-devel-docs set in my ./configure run, I get: make[3]: Entering directory `/home/daniels/x/xorg/xserver/obj-amd64/hw/dmx/doc' GENdmx.txt GEN

Re: [PATCH v2 setxkbmap] man: multiple layouts can be specified (#34118)

2011-02-22 Thread Julien Cristau
, but for now this will do man/setxkbmap.man | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: Spinning in _XReply

2011-02-22 Thread Julien Cristau
On Sat, Jan 29, 2011 at 09:54:37 -0800, Jeremy Huddleston wrote: 2) emacs' error handler seems bugged. Is it legal to call XSync() within the error handler? It certainly seems like it shouldn't. Did we used to actually support this with the xtrans version of libX11? Not as far as I can

Re: [PATCH libXi] Fix invalid read in XIGrabDevice.

2011-02-22 Thread Julien Cristau
) * and they need to be padded with 0 */ -len = req-mask_len * 4; -buff = calloc(1, len); +len = req-mask_len; +buff = calloc(1, len * 4); memcpy(buff, mask-mask, mask-mask_len); SetReqLen(req, len, len); Reviewed-by: Julien Cristau jcris...@debian.org Cheers

Re: [PATCH] libXfixes v5: Pointer barriers

2011-02-23 Thread Julien Cristau
On Wed, Feb 23, 2011 at 11:52:02 -0500, Adam Jackson wrote: diff --git a/include/X11/extensions/Xfixes.h b/include/X11/extensions/Xfixes.h index 0c00310..481531c 100644 --- a/include/X11/extensions/Xfixes.h +++ b/include/X11/extensions/Xfixes.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2006,

Re: [PATCH] vbe: Fix malloc size bug

2011-02-25 Thread Julien Cristau
); +block-VideoModePtr = malloc(sizeof(CARD16) * (i + 1)); memcpy(block-VideoModePtr, modes, sizeof(CARD16) * i); block-VideoModePtr[i] = 0x; Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org

Re: [PATCH:mkfontscale 1/2] Leave room for null terminator in file font name arrays

2011-02-25 Thread Julien Cristau
] == '/') filename = dsprintf(%sfonts.scale, dirname); Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

Re: [PATCH:mkfontscale 2/2] makeList: free partially allocated list on failure

2011-02-25 Thread Julien Cristau
) { +destroyList(first); return NULL; +} next-value = a[i]; next-next = NULL; Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http

[PATCH] input: properly align doubles in InitValuatorClassDeviceStruct

2011-02-25 Thread Julien Cristau
Some architectures (hi, sparc!) are unhappy with unaligned memory accesses. So make sure the axisVal member of ValuatorClassRec has sizeof(double) alignment to avoid crashes and test failures. X.Org bug#34742 https://bugs.freedesktop.org/show_bug.cgi?id=34742 Signed-off-by: Julien Cristau jcris

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-02-28 Thread Julien Cristau
On Mon, Feb 28, 2011 at 02:15:39 +, Matt Turner wrote: Since newport doesn't even compile anymore (since the RAC removal), this probably isn't helpful at all. It builds just fine here. Are you sure? Cheers, Julien ___ xorg-devel@lists.x.org:

Re: [PATCH] Unifdef XGLServer

2011-03-01 Thread Julien Cristau
) !defined( XGLServer ) +#if !defined( XFree86Server ) /* search static functions */ { const _glapi_proc func = get_static_proc_address(funcName); Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org

Re: [PATCH libXi 2/3] Require XI 2 for all XI 2 calls.

2011-03-02 Thread Julien Cristau
On Thu, Sep 9, 2010 at 14:43:02 +1000, Peter Hutterer wrote: Each XI2 call should check _XiCheckExtInit for XI version 2.0 or higher. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Isn't it the client's responsibility to check this with XIQueryVersion? Or handle the BadRequest from

Re: [PATCH 01/11] glx: Remove unused _glapi_get_proc_offset and friends

2011-03-03 Thread Julien Cristau
-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 03/11] glx: unifdef USE_XTHREADS

2011-03-03 Thread Julien Cristau
/glthread.c | 51 --- glx/glthread.h | 46 +- 2 files changed, 1 insertions(+), 96 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 05/11] glx: Simplify _glapi_check_multithread

2011-03-03 Thread Julien Cristau
where it appeared to match. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 49 - 1 files changed, 4 insertions(+), 45 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 06/11] glx: Remove unused _glapi_get_proc_name

2011-03-03 Thread Julien Cristau
On Thu, Mar 3, 2011 at 14:07:20 -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 49 - glx/glapi.h |3 --- 2 files changed, 0 insertions(+), 52 deletions(-) Reviewed-by: Julien Cristau jcris

Re: [PATCH 09/11] glx: Lobotomize _glapi_get_proc_address

2011-03-03 Thread Julien Cristau
On Thu, Mar 3, 2011 at 14:07:23 -0500, Adam Jackson wrote: This isn't a meaningful thing in the indirect glx loader, so just warn if it ever happens and move on. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 39 ++- 1 files changed,

Re: [PATCH 10/11] glx: Update some glapi comments

2011-03-03 Thread Julien Cristau
On Thu, Mar 3, 2011 at 14:07:24 -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 38 ++ 1 files changed, 6 insertions(+), 32 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

[PATCH] configure.ac: bump version for 1.11 development

2011-03-03 Thread Julien Cristau
Signed-off-by: Julien Cristau jcris...@debian.org --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 8da6d21..681f9d9 100644 --- a/configure.ac +++ b/configure.ac @@ -26,8 +26,8 @@ dnl dnl Process this file with autoconf

Re: [PATCH libXvMC 2/2] config: use Automake defaults when checking for library functions.

2011-03-07 Thread Julien Cristau
On Sat, Mar 5, 2011 at 12:01:44 -0500, Gaetan Nadon wrote: Which follows a uniform naming convention. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |2 +- src/XvMC.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Julien

Re: [PATCH libXvMC 1/2] config: move wrapper in its own directory

2011-03-07 Thread Julien Cristau
On Sat, Mar 5, 2011 at 12:01:43 -0500, Gaetan Nadon wrote: This prevents the use of per-target compiler flags. Makefiles are simpler. The -D flags for the wrapper are moved with pre-precessor flags. Fix whitespace issues. Signed-off-by: Gaetan Nadon mems...@videotron.ca ---

Re: [PATCH] libXfixes v5: Pointer barriers

2011-03-07 Thread Julien Cristau
| 60 +++ 3 files changed, 76 insertions(+), 1 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

[PATCH] Xi: fix length checks for swapped clients

2011-03-07 Thread Julien Cristau
ChangeDeviceProperty and XIChangeProperty are followed by some data, so use REQUEST_AT_LEAST_SIZE instead of REQUEST_SIZE_MATCH. X.Org bug#35082 https://bugs.freedesktop.org/show_bug.cgi?id=35082 Reported-by: Markus Fleschutz markus.flesch...@x-software.com Signed-off-by: Julien Cristau jcris

Re: [PATCH] Xi: fix XI2 passive grab reply length calculation

2011-03-08 Thread Julien Cristau
; -WriteSwappedDataToClient(client, rep.num_modifiers * 4, (char*)modifiers_failed); +WriteSwappedDataToClient(client, rep.length * 4, (char*)modifiers_failed); } free(modifiers_failed); return ret; Reviewed-by: Julien Cristau jcris...@debian.org I have a doubt about the swap function

Re: [PATCH v2:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-10 Thread Julien Cristau
On Wed, Mar 9, 2011 at 20:19:16 -0800, Alan Coopersmith wrote: +# Memory checking support +case $host_os in + solaris*) +AC_CHECK_LIB([umem], [umem_alloc], +[MALLOC_DEBUG_ENV='LD_PRELOAD=libumem.so UMEM_DEBUG=default']) +;; + *bsd*|darwin*) +

Re: [PATCH v2:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-10 Thread Julien Cristau
On Thu, Mar 10, 2011 at 10:32:37 +0100, Julien Cristau wrote: On Wed, Mar 9, 2011 at 20:19:16 -0800, Alan Coopersmith wrote: +# Memory checking support +case $host_os in + solaris*) +AC_CHECK_LIB([umem], [umem_alloc], +[MALLOC_DEBUG_ENV='LD_PRELOAD=libumem.so

Re: The following changes since commit 628d16a92a7fa556fbb70bf4a4adf57ec05c190b:

2011-03-10 Thread Julien Cristau
On Fri, Mar 11, 2011 at 08:50:47 +1000, Dave Airlie wrote: On Fri, Mar 11, 2011 at 8:44 AM, Peter Hutterer peter.hutte...@who-t.net wrote: If that is a pull request, you might want to CC keith and add PULL in the subject line. Not sure he notices it otherwise. I did cc Keith on the

Re: [PATCH] glx: Add texbuffer2 support to swrast

2011-03-10 Thread Julien Cristau
On Thu, Mar 10, 2011 at 17:39:35 -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxdriswrast.c |8 1 files changed, 8 insertions(+), 0 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PULL] [libx11] Three static analysis fixes that slipped through the cracks

2011-03-11 Thread Julien Cristau
On Fri, Mar 11, 2011 at 12:49:15 +0200, Erkki Seppala wrote: The following changes since commit 807a7fc0354f2212dfa5ff1f9e4ede56d8e69ef4: Gaetan Nadon (1): Docbook: change the book id to match the xml file basename are available in the git repository at:

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

2011-03-15 Thread Julien Cristau
(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/4] dix: warning fix

2011-03-15 Thread Julien Cristau
On Tue, Mar 15, 2011 at 08:35:12 -0700, Keith Packard wrote: On Tue, 15 Mar 2011 11:05:04 -0400, Adam Jackson a...@redhat.com wrote: - ErrorF([dix] AddResource(%lx, %lx, %lx), client=%d \n, - (unsigned long)id, type, (unsigned long)value, client); + ErrorF([dix]

Re: [PATCH 0/2] minor xtrans cleanup

2011-03-15 Thread Julien Cristau
On Tue, Mar 15, 2011 at 15:50:30 -0400, Adam Jackson wrote: Lets us get rid of Xalloc/Xfree/etc in xserver. Reviewed-by: Julien Cristau jcris...@debian.org for the series. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

2011-03-16 Thread Julien Cristau
On Wed, Mar 16, 2011 at 12:51:00 +1000, Peter Hutterer wrote: On Wed, Mar 16, 2011 at 01:17:17AM +0100, Vincent Lefevre wrote: On 2011-03-16 08:11:21 +1000, Peter Hutterer wrote: evdev has duplication detection built-in so it doesn't add the same device twice. going from the info in the

Re: [PATCH xorg-server] adds nouveau as standard driver for linux systems

2011-03-19 Thread Julien Cristau
On Sat, Mar 19, 2011 at 00:58:58 +0100, Thomas Schneider wrote: nouveau+drm is since the linux kernel version 2.6.34 integrated by default.So since it supports more cards like fermi (sadly not old river nv03 cards) it would be best to set nouveau as standard Signed-off-by: Thomas

Re: [PATCH xorg-server] adds nouveau as standard driver for linux systems

2011-03-20 Thread Julien Cristau
On Sat, Mar 19, 2011 at 18:58:12 +0100, Thomas Schneider wrote: 2011/3/19 Julien Cristau jcris...@debian.org: nv should probably still be added as a fallback on linux.  Also, does this mean the nouveau people will start doing proper ABI management for libdrm_nouveau (i.e. bump SONAME when

Re: [PATCH util-macros 1/2] Add XORG_WITH_W3M for HTML to text conversion

2011-03-22 Thread Julien Cristau
On Tue, Mar 22, 2011 at 17:27:22 -0400, Gaetan Nadon wrote: The macros have to be backward compatible. In 3 years from now, no one will have 4.3 installed, so we will need to move up to 4.8. Building older versions of tarballs with older versions of docbook will not be possible. Really?

Re: [PATCH] configure: actually require macros 1.13

2011-03-22 Thread Julien Cristau
On Wed, Mar 23, 2011 at 10:33:41 +1000, Peter Hutterer wrote: Introduced in 6a5bf15fa99cf5b2358b3b3e2f29e5044aa8724a Reported-by: Dave Airlie airl...@redhat.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Julien Cristau jcris...@debian.org --- configure.ac |2

Re: [PATCH inputproto] specs: move erroneous Errors: line to where it belongs

2011-03-23 Thread Julien Cristau
On Wed, Mar 23, 2011 at 13:53:37 +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- specs/XIproto.txt |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH modular] release.sh: Generate error for missing arguments

2011-03-23 Thread Julien Cristau
On Wed, Mar 23, 2011 at 12:35:56 +0100, Dirk Wallenstein wrote: On Sun, Mar 13, 2011 at 08:52:42AM -0700, Dan Nicholson wrote: On Sun, Mar 13, 2011 at 3:35 AM, Dirk Wallenstein hals...@t-online.de wrote: All three arguments are required.  Otherwise git-rev-list will abort the script

Re: Alignment error in libXi

2011-03-26 Thread Julien Cristau
On Fri, Mar 25, 2011 at 06:31:38 +, Matt Turner wrote: Oh, I didn't realize it had already been fixed. Odd that it was fixed, reviewed, and tested without another comment in this thread. Guess I just missed the patch. The followup with patch was only on -devel. Cheers, Julien

Re: [PATCH] Xi: take XI2 requests into account also for the swapping case.

2011-03-27 Thread Julien Cristau
On Sun, Mar 27, 2011 at 19:15:18 +0200, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- Xi/extinit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xi/extinit.c b/Xi/extinit.c index 46d3459..5d695e3 100644 --- a/Xi/extinit.c +++

Re: [PATCH] Xi: take XI2 requests into account also for the swapping case.

2011-03-27 Thread Julien Cristau
On Sun, Mar 27, 2011 at 21:32:10 +0200, Matthieu Herrb wrote: On Sun, Mar 27, 2011 at 09:06:08PM +0200, Julien Cristau wrote: This seems dangerous if you're, say, building an X server that only supports XI 2.0 against the XI 2.1 headers. Should probably be if (stuff-data = ARRAY_SIZE

Re: [PATCH 1/4] Xi: take XI2 requests into account also for the swapping case.

2011-04-01 Thread Julien Cristau
On Fri, Apr 1, 2011 at 23:05:40 +0200, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- Xi/extinit.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 2/4] Xi: add XI_Focus{In,Out} to swapped events.

2011-04-01 Thread Julien Cristau
On Fri, Apr 1, 2011 at 23:05:41 +0200, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- Xi/extinit.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 3/4] Xext: fix test on extension number for the swapped case.

2011-04-01 Thread Julien Cristau
On Fri, Apr 1, 2011 at 23:05:42 +0200, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- Xext/geext.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 4/4] Xi: fix querydevice request swapping

2011-04-01 Thread Julien Cristau
* WriteReplyToClient(client, sizeof(xXIQueryDeviceReply), rep); -WriteToClient(client, rep.length * 4, ptr); +WriteToClient(client, len, ptr); free(ptr); free(skip); return rc; Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH:xdm] Add chooser shadow man page pointing to xdm man page

2011-04-01 Thread Julien Cristau
On Fri, Apr 1, 2011 at 11:02:49 -0700, Alan Coopersmith wrote: https://bugs.freedesktop.org/show_bug.cgi?id=35868 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- man/Makefile.am |2 +- man/chooser.man |1 + 2 files changed, 2 insertions(+), 1 deletions(-)

Re: Question about the modesetting on X server

2011-04-28 Thread Julien Cristau
On Thu, Apr 28, 2011 at 00:25:40 -0700, Alan Coopersmith wrote: On 04/27/11 10:26 PM, Huang, FrankR wrote: Okay. I understand that. But how the X server knows that no cliens are connected again? It keeps a count of open clients, increments it when a new client connects, decrements it

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-04-29 Thread Julien Cristau
On Thu, Apr 28, 2011 at 13:27:22 -0700, Jesse Barnes wrote: diff --git a/glx/glxdri2.c b/glx/glxdri2.c index d979717..654b4ae 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -192,8 +192,17 @@ __glXdriSwapEvent(ClientPtr client, void *data, int type, CARD64 ust, wire.ust_lo = ust

Re: `PKG_CHECK_MODULES(X, xproto)'?

2011-04-29 Thread Julien Cristau
On Thu, Apr 28, 2011 at 21:22:45 -0700, Fred Liu wrote: Hi, I am following the instruction from Building all modules with the build scripts to build X11R76 as following: util/modular/build.sh $PREFIX ... ... ./configure: line 4899: syntax error near unexpected token `X,' ./configure:

Re: [PATCH:twm] Fix: menus.c:2374: warning: implicit declaration of function `putenv`

2011-05-10 Thread Julien Cristau
...@oracle.com --- configure.ac|1 + src/Makefile.am |2 +- src/menus.c |4 src/twm.h |4 4 files changed, 10 insertions(+), 1 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg

Re: [PATCH] bsd: Add support for -novtswitch.

2011-05-14 Thread Julien Cristau
On Sat, May 14, 2011 at 12:53:48 +0200, Matthieu Herrb wrote: On Fri, May 13, 2011 at 04:57:13PM +0200, Cyril Brulebois wrote: VT switching back to the initial VT is possible in the following case: #if defined (SYSCONS_SUPPORT) || defined (PCVT_SUPPORT) Make it possible to prevent

Re: [PATCH] bsd: Add support for -novtswitch.

2011-05-14 Thread Julien Cristau
On Fri, May 13, 2011 at 16:57:13 +0200, Cyril Brulebois wrote: VT switching back to the initial VT is possible in the following case: #if defined (SYSCONS_SUPPORT) || defined (PCVT_SUPPORT) Make it possible to prevent that from happening if -novtswitch was passed, which should make the

Re: [PATCH:xdm 1/5] Fix potential memory leak in allocation failure cleanup path

2011-05-14 Thread Julien Cristau
/ ] Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- xdm/util.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) For the series, Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] linux: Clean up filenames used in Linux VT init.

2011-05-14 Thread Julien Cristau
On Sat, May 14, 2011 at 13:38:27 -0700, Cody Maloney wrote: According to the comment in the Linux kernel source file drivers/tty/vt/vt_ioctl.c /dev/tty0 points to /dev/console, so we should just go to /dev/console, and virtual terminals are always labeled /dev/ttyN where N is

Re: [PATCH] test: only test for double alignment on 64 bit. (#36986)

2011-05-19 Thread Julien Cristau
On Thu, May 19, 2011 at 14:54:28 +1000, Peter Hutterer wrote: X.Org Bug 36986 http://bugs.freedesktop.org/show_bug.cgi?id=36986 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- On Wed, May 18, 2011 at 12:45:05AM -0700, Keith Packard wrote: On Wed, 18 May 2011 13:30:44 +1000,

Re: [PATCH xserver] config/udev: add input subsystem filter for udev events

2011-05-19 Thread Julien Cristau
On Thu, May 19, 2011 at 16:22:22 +0800, Daniel Kurtz wrote: libudev allows adding an efficient in-kernel filter on udev events. Since we manually filter for ID_INPUT anyway, it seems reasonable to ask the kernel to send only events for the input subsystem. This filtering is performed both

Re: [PATCH xinput] Announce support for XI 2.0 to the server.

2011-06-02 Thread Julien Cristau
so make sure we're clamining our version correctly. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/xinput.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH xinput] Remove superfluous comment.

2011-06-02 Thread Julien Cristau
Hutterer peter.hutte...@who-t.net --- src/list.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Acked-by: Julien Cristau jcris...@debian.org Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: Build fixes (was Anything more for xproto 7.0.22?)

2011-06-05 Thread Julien Cristau
On Sat, Jun 4, 2011 at 09:25:07 -0400, Gaetan Nadon wrote: The DocBook/XML olink databases (this is what those files are) are installed in the location provided by the specs/Makefile variable sgmldbsdir which is set to $(XORG_SGML_PATH)/X11/dbs. The value of XORG_SGML_PATH is obtained from

Re: Build fixes (was Anything more for xproto 7.0.22?)

2011-06-05 Thread Julien Cristau
On Sun, Jun 5, 2011 at 11:22:31 -0400, Gaetan Nadon wrote: An alternative is to install the *.db files in their respective packages and have the xorg-sgml-doctools masterdb point to the packages. Either xorg-sgml-doctools doesn't know where the packages are installed, and shouldn't have to

Re: xf86-video-geode: Changes to 'master'

2010-09-30 Thread Julien Cristau
On Thu, Sep 30, 2010 at 13:56:27 +0800, Huang, FrankR wrote: I definitely know MODE_OK will be returned in this function now for every condition. But you should know my patch is based on the patch Otavio committed on 5/29/2010. If there is some condition we need give MODE_XXX, we can add

Re: xf86-video-geode: Changes to 'master'

2010-09-30 Thread Julien Cristau
On Thu, Sep 30, 2010 at 15:38:07 +0800, Huang, FrankR wrote: Agree. But that will revert totally 5/29/2010 patch. It will be exactly equivalent to the current code. So no. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: problem with multithreaded application and Xlib

2010-09-30 Thread Julien Cristau
On Thu, Sep 30, 2010 at 17:44:23 +0200, Francesco Abbate wrote: I will be grateful if I could have at least some hints. Thank you very much in advance. Did you try the libxcb patch suggested by Peter? Cheers, Julien ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Julien Cristau
On Fri, Oct 1, 2010 at 12:16:55 -0400, Trevor Woerner wrote: On Fri, Oct 1, 2010 at 11:37 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: Also, drivers are supposed to work with some older servers as well, at least some of them.  So even if removing that line for the current server is

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Julien Cristau
On Fri, Oct 1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: #if ABI_VIDEODRV_VERSION SET_ABI_VERSION(9, 0) old code #else new code #endif That would work perfectly, if the ABI was bumped by every change which breaks

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Julien Cristau
On Fri, Oct 1, 2010 at 13:14:51 -0400, Trevor Woerner wrote: Irregardless of which solution is chosen, if someone wanted to compile a driver for an older server, they'd still have to checkout an older version of the server code to compile against. Wouldn't they? What are the chances a newer

  1   2   3   4   5   6   7   8   9   10   >