[PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-01-21 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com RandR doesn't seem to deal with pseudocolour at all, so without this the pseudocolour palette never gets loaded to the hardware. v2: Move logic into xf86_crtc_supports_gamma(). Signed-off-by: Michel Dänzer daen...@vmware.com --- hw/xfree86/modes

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2011-01-28 Thread Michel Dänzer
even CC the list anymore for this, YMMV. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH x11perf] Make sure that window fits into screen.

2011-01-28 Thread Michel Dänzer
the default window size. The numbers are not comparable if the operation dimensions are different. It might be better to refuse tests that can't fit. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH v2 x11perf 3/3] Omit benchmarks reading contents of window that is larger than screen.

2011-01-31 Thread Michel Dänzer
Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH v2 x11perf 3/3] Omit benchmarks reading contents of window that is larger than screen.

2011-02-01 Thread Michel Dänzer
On Die, 2011-02-01 at 10:59 +0200, Rami Ylimäki wrote: On 01/31/2011 06:08 PM, Michel Dänzer wrote: On Mon, 2011-01-31 at 15:48 +0200, Rami Ylimäki wrote: Signed-off-by: Rami Ylimäkirami.ylim...@vincit.fi --- do_blt.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions

Re: [PATCH 7/9] dri2: Send events only to known clients

2011-02-04 Thread Michel Dänzer
entries that were never added. (Bug #31086)'). -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [PATCH 7/9] dri2: Send events only to known clients

2011-02-04 Thread Michel Dänzer
On Fre, 2011-02-04 at 16:38 +0200, Pauli Nieminen wrote: On 04/02/11 10:44 +0100, ext Michel Dänzer wrote: On Don, 2011-02-03 at 19:48 +0200, Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com If client disconnects and new client gets same id DRI2 events may end

Re: [PATCH 1/3] exa/driver: set pExaPixmap-use_gpu_copy to the right value

2011-02-07 Thread Michel Dänzer
-by: Michel Dänzer mic...@daenzer.net Signed-off-by: Maarten Maathuis madman2...@gmail.com Merged all three of these patches. 246d40b..541b250 master - master -- keith.pack...@intel.com These three exa patches should probably go into 1.9 branch. Agreed

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-09 Thread Michel Dänzer
On Fre, 2011-01-21 at 10:15 +0100, Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com RandR doesn't seem to deal with pseudocolour at all, so without this the pseudocolour palette never gets loaded to the hardware. v2: Move logic into xf86_crtc_supports_gamma(). Anyone? Should

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-09 Thread Michel Dänzer
On Mit, 2011-02-09 at 12:43 -0800, Keith Packard wrote: On Wed, 09 Feb 2011 10:48:24 +0100, Michel Dänzer mic...@daenzer.net wrote: Anyone? Should the server abort in this case instead? It certainly can't work properly as it is. Sure looks like any driver that supports the gamma

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
-last_time_front_mixed_pixmap be updated in ExaBlockHandler() as well? -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 08:42 -0800, Keith Packard wrote: On Thu, 10 Feb 2011 07:41:27 +0100, Michel Dänzer mic...@daenzer.net wrote: Yes, and the patch fixes it at least with the Gallium Xorg state tracker. Ok. Seems like this patch should include other visual types too; should

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 18:46 +0100, Michel Dänzer wrote: On Don, 2011-02-10 at 08:42 -0800, Keith Packard wrote: On Thu, 10 Feb 2011 07:41:27 +0100, Michel Dänzer mic...@daenzer.net wrote: Yes, and the patch fixes it at least with the Gallium Xorg state tracker. Ok. Seems like

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
fixed, Reviewed-by: Michel Dänzer mic...@daenzer.net -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 20:44 +0100, Maarten Maathuis wrote: 2011/2/10 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:15 +0100, Maarten Maathuis wrote: - It turns out that part of the problem was actually on the driver side. - The performance loss is not worth the small visual

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 15:23 -0800, Keith Packard wrote: On Thu, 10 Feb 2011 18:56:58 +0100, Michel Dänzer mic...@daenzer.net wrote: Though I'm afraid I don't have the time or interest for a more complete solution at this point. Can this go in for now, even if it only fixes pseudocolour

Re: [Mesa-dev] Please mark _glapi_proc in xserver/glx/glapi.c as PUBLIC

2011-02-11 Thread Michel Dänzer
gone to the xorg-devel list. :) Moving there. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] Revert exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2011-02-19 Thread Michel Dänzer
the loss for a minor improvement that may not even exist on someone else's computer. Signed-off-by: Maarten Maathuis madman2...@gmail.com Reviewed-by: Michel Dänzer mic...@daenzer.net -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-21 Thread Michel Dänzer
On Fre, 2011-02-18 at 14:23 +0100, Maarten Maathuis wrote: 2011/2/11 Maarten Maathuis madman2...@gmail.com: 2011/2/11 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:44 +0100, Maarten Maathuis wrote: 2011/2/10 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:15

[PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

2011-02-24 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com If there's a GPU copy and a non-zero devKind was passed in, set the GPU copy pitch to that instead of to a possibly bogus value derived from the new width. This is e.g. used by the radeon driver's drmmode_xf86crtc_resize hook, fixes https

[PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information for the compositing manager's output window (typically the Composite Overlay Window or root window) may become stale

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 06:10 -0700, Jakob Bornecrantz wrote: On Mar 25, 2011, at 13:47, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 15:45 +0100, Mario Kleiner wrote: On Mar 25, 2011, at 3:32 PM, Michel Dänzer wrote: On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 17:27 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 03:32:06PM +0100, ext Michel Dänzer wrote: On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com

[PATCH xserver 1/2] dri2: Always re-generate front buffer information when asked for it.

2011-03-25 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Otherwise we might keep stale cached information, e.g. after the driver performed page flipping. This is part of the fix for https://bugs.freedesktop.org/show_bug.cgi?id=35452 . Signed-off-by: Michel Dänzer daen...@vmware.com Reviewed-by: Ville Syrjälä

[PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information for the compositing manager's output window (typically the Composite Overlay Window or root window) may become stale

Re: [PATCH 01/11] xfree86: dri2: fix memory leak in DRI2AddDrawableRef

2011-03-26 Thread Michel Dänzer
fail? (Looks to be an issue across the series) Also, if the second AddResource call fails, the effects of the first one should be reversed as well. But this is certainly an improvement even without that. -- Earthling Michel Dänzer |http://www.vmware.com Libre software

[PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com The latter calls the former, let's cut the middle man and eliminate a branch in a hot path. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_priv.h |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/exa/exa_priv.h b

Re: [PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Michel Dänzer
On Sam, 2011-03-26 at 11:50 +, Maarten Maathuis wrote: 2011/3/26 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer daen...@vmware.com The latter calls the former, let's cut the middle man and eliminate a branch in a hot path. Signed-off-by: Michel Dänzer daen...@vmware.com

Re: [PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-28 Thread Michel Dänzer
On Son, 2011-03-27 at 23:00 -0700, Keith Packard wrote: On Fri, 25 Mar 2011 18:26:56 +0100, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping

Re: [PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-28 Thread Michel Dänzer
On Son, 2011-03-27 at 04:41 +0200, Cyril Brulebois wrote: (Mode I'm-discovering-the-code on) Michel Dänzer mic...@daenzer.net (26/03/2011): From: Michel Dänzer daen...@vmware.com The latter calls the former, let's cut the middle man and eliminate a branch in a hot path. Signed

[PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-28 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com The latter calls the former, let's cut the middle man and eliminate a branch in a hot path. According to Git history, ExaSetPixmapPriv was never used anywhere, just drop it. Signed-off-by: Michel Dänzer daen...@vmware.com Reviewed-by: Cyril Brulebois k

Re: [PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-28 Thread Michel Dänzer
On Mon, 2011-03-28 at 08:47 -0700, Keith Packard wrote: On Mon, 28 Mar 2011 10:04:23 +0200, Michel Dänzer mic...@daenzer.net wrote: So once again, a fix is delayed because it's not considered quite perfect yet. Kristian is the maintainer of the DRI2 code, and so should be involved

Re: [PATCH] Track damage for fbTrapezoids() and fbTriangles().

2011-03-28 Thread Michel Dänzer
) { int i; Don't you also need to call DamageRegionProcessPending() after the operation? -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel

Re: [PATCH] Track damage for fbTrapezoids() and fbTriangles().

2011-03-29 Thread Michel Dänzer
it does several divisions per trapezoid. V2: Call DamageRegionProcessPending() - pointed out by Michel Dänzer. V3: Call DamageRegionProcessPending() *after* rendering - pointed out by Maarten Maathuis I did say after. :) Reviewed-by: Michel Dänzer mic...@daenzer.net -- Earthling Michel

Re: [PATCH] glx: Fix lifetime tracking for pixmaps

2011-03-29 Thread Michel Dänzer
, __glXDrawableRes, pGlxDraw)) { Is pDraw-id == drawableId always true here for windows? That was one of the issues previously proposed fixes in this area were trying to address. Looks good otherwise though. -- Earthling Michel Dänzer |http://www.vmware.com Libre software

Re: [PATCH] glx: Fix lifetime tracking for pixmaps

2011-03-30 Thread Michel Dänzer
On Die, 2011-03-29 at 09:48 -0400, Adam Jackson wrote: On Tue, 2011-03-29 at 10:09 +0200, Michel Dänzer wrote: On Mon, 2011-03-28 at 12:40 -0400, Adam Jackson wrote: diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 9b4bc9e..9d60bdb 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c

Re: [PATCH] [RFC] dix: don't use CopyWindow in driver level interface.

2011-03-31 Thread Michel Dänzer
= -pPixmap-screen_x; + yoff = -pPixmap-screen_y; +} +#endif +RegionTranslate(rgnDst, xoff, yoff); Could only call RegionTranslate in the if block above, and move the x/yoff locals there as well (or eliminate them altogether). -- Earthling Michel Dänzer

Re: [PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-04-06 Thread Michel Dänzer
On Son, 2011-03-27 at 23:00 -0700, Keith Packard wrote: On Fri, 25 Mar 2011 18:26:56 +0100, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping

Re: [PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-04-07 Thread Michel Dänzer
On Mit, 2011-04-06 at 09:50 -0700, Keith Packard wrote: On Wed, 06 Apr 2011 10:19:01 +0200, Michel Dänzer mic...@daenzer.net wrote: 10 days have passed. I hoped you would take a few minutes and write a more efficient version. Well, that's not what you said in the parts I quoted

Re: [PATCH sis v2 04/15] Fix suggest parentheses around operand of ‘!’ compiler warnings.

2011-04-08 Thread Michel Dänzer
, CRT2 can't be switched off while CRT1 is off\n); The outer parens around the ! expressions are superfluous. The bug was just that the ! was inside the existing parens instead of outside them. -- Earthling Michel Dänzer |http://www.vmware.com Libre software

Re: [PULL] Various render changes

2011-04-08 Thread Michel Dänzer
is updated but not xserver? -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH sis v2 04/15] Fix suggest parentheses around operand of ‘!’ compiler warnings.

2011-04-08 Thread Michel Dänzer
On Fre, 2011-04-08 at 09:13 +0200, Michel Dänzer wrote: On Don, 2011-04-07 at 23:47 +0300, Timo Aaltonen wrote: diff --git a/src/sis_utility.c b/src/sis_utility.c index 64d8919..0892cf5 100644 --- a/src/sis_utility.c +++ b/src/sis_utility.c @@ -523,7 +523,7 @@ SISSwitchCRT2Type

Re: [PULL] Various render changes

2011-04-11 Thread Michel Dänzer
On Fre, 2011-04-08 at 18:37 +0200, Soeren Sandmann wrote: Michel Dänzer mic...@daenzer.net writes: On Don, 2011-04-07 at 19:41 +0200, Soeren Sandmann wrote: The trap offsets change depends on a change to pixman that I will push as soon as the changes below are in master. What's

Re: [PATCH] glx: Attempt to load swrastg too

2011-04-19 Thread Michel Dänzer
, __DRI_SWRAST_VERSION); +} +if (screen-driver == NULL) { I think it would be better to install swrastg as swrast_dri.so. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH 3/6] Use abs() on integers, not fabs()

2011-04-28 Thread Michel Dänzer
-VRefresh - desired-VRefresh) - fabs(best-VRefresh - desired-VRefresh))) { + (abs(scan-VRefresh - desired-VRefresh) + abs(best-VRefresh - desired-VRefresh))) { VRefresh is a float. -- Earthling Michel Dänzer |http://www.vmware.com Libre software

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-04-29 Thread Michel Dänzer
= 4; } else { cur_minor = 1; } This bugfix should probably be separate. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-04-29 Thread Michel Dänzer
On Fre, 2011-04-29 at 08:52 +0200, Michel Dänzer wrote: On Don, 2011-04-28 at 13:27 -0700, Jesse Barnes wrote: @@ -1114,7 +1169,7 @@ DRI2ScreenInit(ScreenPtr pScreen, DRI2InfoPtr info) ds-ScheduleSwap = info-ScheduleSwap; ds-ScheduleWaitMSC = info-ScheduleWaitMSC; ds-GetMSC

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Michel Dänzer
very high. The whole mess looks like a simple driver bug to me. I think the xserver patches are still necessary, otherwise how are the cached DRI2 pPriv-buffers updated for other windows sharing the same pixmap? -- Earthling Michel Dänzer |http://www.vmware.com Libre

Re: [PATCH xf86-video-ati 1/2] dri2: Update front buffer pixmap and name before exchanging buffers

2011-05-05 Thread Michel Dänzer
; + +return TRUE; +} Maybe at least some of this could be short-circuited if it's still the same pixmap. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Michel Dänzer
. :) Please do this. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH xserver] dri2: Don't send so many needless invalidate events

2011-05-06 Thread Michel Dänzer
On Fre, 2011-05-06 at 18:18 +0300, ville.syrj...@nokia.com wrote: From: Ville Syrjälä ville.syrj...@nokia.com Only send invalidate events for drawables if some client has requested some buffers. Signed-off-by: Ville Syrjälä ville.syrj...@nokia.com Reviewed-by: Michel Dänzer mic

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-10 Thread Michel Dänzer
with the client-side GLX drawable lifetime either. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives

[PATCH xserver 1/7] EXA: Don't call miComputeCompositeRegion() when rendering glyphs to a mask.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com We know the mask covers the glyph extents. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_render.c | 74 ++--- 1 files changed, 42 insertions(+), 32 deletions(-) diff --git a/exa/exa_render.c

[PATCH xserver 2/7] EXA: Use round robin instead of rand() for choosing eviction position.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com This should be just as good on average but is less expensive. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_glyphs.c |4 ++-- exa/exa_priv.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/exa/exa_glyphs.c b

[PATCH xserver 3/7] EXA: Hardcode glyph cache dimensions to allow more efficient code generation.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_glyphs.c | 43 --- exa/exa_priv.h |3 --- 2 files changed, 20 insertions(+), 26 deletions(-) diff --git a/exa/exa_glyphs.c b/exa/exa_glyphs.c index

[PATCH xserver 4/7] EXA: Replace hash table with glyph privates for glyph cache lookup.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Inspired by the corresponding intel driver change by Chris Wilson. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa.c|3 + exa/exa_glyphs.c | 219 ++ exa/exa_priv.h | 20

[PATCH xserver 5/7] EXA: Glyph rects optimizations.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Mostly reducing function call argument passing overhead. Also remove unused rect member pDst. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_glyphs.c | 87 -- exa/exa_priv.h |1 - 2

[PATCH xserver] EXA: Avoid GPU memory readback on ImageGlyphBlt fallback.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com See https://bugs.freedesktop.org/show_bug.cgi?id=35197 . Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_unaccel.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c index

[PATCH xserver] EXA: Avoid GPU memory readback for PolyGlyphBlt fallbacks.

2011-05-17 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_unaccel.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c index 5d26b77..2bdaede 100644 --- a/exa/exa_unaccel.c +++ b/exa

Re: [PATCH xserver] EXA: Avoid GPU memory readback for PolyGlyphBlt fallbacks.

2011-05-17 Thread Michel Dänzer
On Die, 2011-05-17 at 15:03 +0200, Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_unaccel.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c

Re: [PATCH evdev 3/4] Add a property to toggle fnmode on Apple keyboards

2011-05-18 Thread Michel Dänzer
, so the function keys produce Fx by default, but I can use the multimedia functions with the fn key) I really like the idea behind this patch though. :) -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI

[PATCH xserver 1/4] EXA: Don't call miComputeCompositeRegion() when rendering glyphs to a mask.

2011-05-18 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com We know the mask covers the glyph extents. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_render.c | 74 ++--- 1 files changed, 42 insertions(+), 32 deletions(-) diff --git a/exa/exa_render.c

[PATCH xserver 2/4] EXA: Hardcode glyph cache dimensions to allow more efficient code generation.

2011-05-18 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_glyphs.c | 45 + exa/exa_priv.h |3 --- 2 files changed, 21 insertions(+), 27 deletions(-) diff --git a/exa/exa_glyphs.c b/exa/exa_glyphs.c

[PATCH xserver 3/4] EXA: Glyph rects optimizations.

2011-05-18 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Mostly reducing function call argument passing overhead. Also remove unused rect member pDst. Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_glyphs.c | 87 -- exa/exa_priv.h |1 - 2

[PATCH xserver 4/4] EXA: Replace hash table with glyph privates for glyph cache lookup.

2011-05-18 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Inspired by the corresponding intel driver change by Chris Wilson. Also drop the special case for filling the cache initially, doesn't seem to buy anything at this point. v2: Always update eviction position after adding new glyph to cache. Signed-off

Re: [PATCH xserver 2/7] EXA: Use round robin instead of rand() for choosing eviction position.

2011-05-18 Thread Michel Dänzer
On Die, 2011-05-17 at 13:08 -0400, Owen Taylor wrote: On Tue, 2011-05-17 at 18:32 +0200, Michel Dänzer wrote: On Die, 2011-05-17 at 11:53 -0400, Owen Taylor wrote: If libc rand() is too slow, then some inlined linear-congruential generator could shave a few cycles. I'm afraid

Re: [PATCH evdev 3/4] Add a property to toggle fnmode on Apple keyboards

2011-05-19 Thread Michel Dänzer
On Don, 2011-05-19 at 11:00 +1000, Peter Hutterer wrote: On Wed, May 18, 2011 at 10:38:36AM +0200, Michel Dänzer wrote: On Mit, 2011-05-18 at 15:00 +1000, Peter Hutterer wrote: On Apple keyboards, the multimedia function keys are overlaid with the F keys. F1 is also BrightnessDown, F10

Re: [PATCH v2 evdev 3/4] Add a property to toggle function key mode

2011-05-20 Thread Michel Dänzer
) +return -1; [...] +if (read(fd, retvalue, 1) != 1) +return FKEYMODE_UNKNOWN; These would leak fd, wouldn't they? Looks good to me otherwise. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X

Re: [PATCH v3 3/4] Add a property to toggle function key mode

2011-05-23 Thread Michel Dänzer
(affected are get_fnmode and set_fnmode) Reviewed-by: Michel Dänzer mic...@daenzer.net Thanks! -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
: Fix resizing when acceleration is disabled'), which indicates it might be necessary when resizing the screen with acceleration disabled. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
in the commit text. Whenever possible, it should be preferable to check for (the lack of) a feature directly rather than indirectly via a version. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
SET_ABI_VERSION(9, 0) old code #else new code #endif That would work perfectly, if the ABI was bumped by every change which breaks the ABI... -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
On Fre, 2010-10-01 at 18:57 +0200, Julien Cristau wrote: On Fri, Oct 1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: #if ABI_VIDEODRV_VERSION SET_ABI_VERSION(9, 0) old code #else new code #endif That would work

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-04 Thread Michel Dänzer
On Sam, 2010-10-02 at 20:53 +0300, Adrian Bunk wrote: On Fri, Oct 01, 2010 at 07:23:05PM +0200, Michel Dänzer wrote: On Fre, 2010-10-01 at 18:57 +0200, Julien Cristau wrote: On Fri, Oct 1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: On Fre, 2010-10-01 at 18:27 +0200, Julien

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-29 Thread Michel Dänzer
'classic' scheme at least. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-30 Thread Michel Dänzer
On Fre, 2010-10-29 at 12:21 -0700, Eric Anholt wrote: On Fri, 29 Oct 2010 10:46:00 +0200, Michel Dänzer mic...@daenzer.net wrote: On Don, 2010-10-28 at 20:46 -0700, Eric Anholt wrote: In all these cases, any rendering implied by this damage has already occurred, and we want to get

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-31 Thread Michel Dänzer
On Sam, 2010-10-30 at 12:36 -0700, Keith Packard wrote: On Sat, 30 Oct 2010 18:07:19 +0200, Michel Dänzer mic...@daenzer.net wrote: Right, but as long as there's at least one rendering operation in between, at that point EXA will synchronize the pixmap copies according to the accumulated

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-11-01 Thread Michel Dänzer
from making this change. Are there any? -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 2/2] Set DamageSetReportAfterOp to true for the damage extension

2010-11-11 Thread Michel Dänzer
] Merged. c80c417..333b6ed master - master My concerns haven't been addressed... Guess I'll reassign any bug reports to you guys? -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: xserver: Branch 'server-1.9-branch' - 3 commits

2010-11-15 Thread Michel Dänzer
understand that Eric and Keith don't care about breaking EXA, but it's sad to see that apparently that's considered okay even for a 'stable' branch. 0 -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer

Re: DamageRegionAppend versus DamageDamageRegion (was Re: xserver: Branch 'server-1.9-branch' - 3 commits)

2010-11-16 Thread Michel Dänzer
On Mon, 2010-11-15 at 11:24 -0800, Jeremy Huddleston wrote: On Nov 15, 2010, at 01:33, Michel Dänzer wrote: On Sam, 2010-11-13 at 15:21 -0800, Jeremy Huddleston wrote: commit dfda3c696dd72ecc5cc4fa69d8bb4521ba554cf3 Author: Eric Anholt e...@anholt.net Date: Thu Oct 28 20:46:22

Re: [PATCH] Build libxf86config with -fPIC.

2010-11-23 Thread Michel Dänzer
it's not required for them and it reserves a precious register on x86. Building static libraries with -fPIC is an established solution for linking libraries with no ABI guarantees into shared libraries. -- Earthling Michel Dänzer |http://www.vmware.com Libre software

Re: Q: puzzle about the index of PrepareAccess

2010-12-03 Thread Michel Dänzer
-allocated space to maintain state for PrepareAccess() * and FinishAccess() in. Note that PrepareAccess() is only called once per * pixmap and operation, regardless of whether the pixmap is used as a * destination and/or source, and the index may not reflect the usage. -- Earthling Michel

Re: [PATCH 1/2] exa: Only call driver finish access hook when needed.

2010-12-10 Thread Michel Dänzer
prepare access. */ if (pExaScr-fallback_counter) exaPrepareAccess(pPixmap-drawable, EXA_PREPARE_AUX_DEST); Not sure this is really necessary but I guess it doesn't hurt. Should be a separate patch though. -- Earthling Michel Dänzer |http://www.vmware.com Libre

Re: [PATCH 2/2] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-10 Thread Michel Dänzer
migration overhead? Do you have a simple recipe for reproducing high latencies? -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel

Re: Black Screen while using /dev/fb1

2010-12-10 Thread Michel Dänzer
On Fre, 2010-12-10 at 15:47 +0530, umang gupta wrote: Please find attached log file for case mentioned . [...] ø em class=parametercodea class=link [...] This doesn't look like an X log file. :) -- Earthling Michel Dänzer

Re: [PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-10 Thread Michel Dänzer
...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc: Michel Dänzer daen...@vmware.com --- glx/glxcmds.c |6 ++ glx/glxdrawable.h |3 +++ glx/glxext.c | 15 ++- 3 files changed, 19 insertions(+), 5 deletions(-) diff --git a/glx/glxcmds.c b/glx

Re: [PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-10 Thread Michel Dänzer
with another bug fix from Michel Dänzer, https://bugs.freedesktop.org/show_bug.cgi?id=28181 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc: Michel Dänzer daen...@vmware.com Reviewed-by: Michel Dänzer mic...@daenzer.net I'd wait for Kristian's

Re: Swap limit

2010-12-13 Thread Michel Dänzer
probably something similar for the AVIVO display engine. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 1/3] exa/driver: set pExaPixmap-use_gpu_copy to the right value

2010-12-14 Thread Michel Dänzer
On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: - Not sure if it was causing problems, but you never know. Signed-off-by: Maarten Maathuis madman2...@gmail.com Reviewed-by: Michel Dänzer mic...@daenzer.net -- Earthling Michel Dänzer |http

Re: [PATCH 2/3] exa: Only call driver FinishAccess hook if PrepareAccess hook succeeded.

2010-12-14 Thread Michel Dänzer
On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: Signed-off-by: Maarten Maathuis madman2...@gmail.com Reviewed-by: Michel Dänzer mic...@daenzer.net -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-14 Thread Michel Dänzer
sacrifice some throughput, not sure how much, Shouldn't be hard to measure. but users tend to respond poorly to unexpected latency IMO. I'm sure some do, but I also suspect some do to unexpected slowness. :} -- Earthling Michel Dänzer |http://www.vmware.com Libre software

Re: [PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-16 Thread Michel Dänzer
[ Dropping dri-devel list as this seems strictly an xserver issue ] On Fre, 2010-12-10 at 14:49 +0100, Michel Dänzer wrote: On Fre, 2010-12-10 at 13:38 +, Chris Wilson wrote: Although there may be more than one resource handles pointing to the Drawable, we only want to destroy it once

Re: [PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-16 Thread Michel Dänzer
on the first instance. v2: Apply fixes and combine with another bug fix from Michel Dänzer, https://bugs.freedesktop.org/show_bug.cgi?id=28181 v3: Just use the refcnt and don't try to free other resources in the DrawableGone callback. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Can

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-20 Thread Michel Dänzer
On Mon, 2010-12-20 at 15:46 +0100, Maarten Maathuis wrote: 2010/12/14 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: - Apps like xterm can trigger a lot of fallback rendering. - This can lead to (annoyingly) high latencies, because you have

EXA: Fix crash with fill using 1x1 tile of depth 8 (bug #24703).

2010-12-22 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Fixes http://bugs.freedesktop.org/show_bug.cgi?id=24703 . Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_accel.c |2 ++ exa/exa_unaccel.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exa/exa_accel.c b/exa

Re: [PATCH] EXA: Fix crash with fill using 1x1 tile of depth 8 (bug #24703).

2010-12-23 Thread Michel Dänzer
On Mit, 2010-12-22 at 11:38 -0800, Keith Packard wrote: On Wed, 22 Dec 2010 11:45:36 +0100, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer daen...@vmware.com Fixes http://bugs.freedesktop.org/show_bug.cgi?id=24703 . Signed-off-by: Michel Dänzer daen...@vmware.com

  1   2   3   4   5   6   7   8   9   10   >