Re: [PATCH 1/6] DownloadFromScreenCS: download via a scratch BO if pixmap domain is unknown

2010-09-01 Thread Michel Dänzer
On Mit, 2010-09-01 at 10:39 +1200, Karl Tomlinson wrote: Michel Dänzer writes: On Mon, 2010-08-23 at 18:27 +1200, Karl Tomlinson wrote: radeon_bo_is_busy() may return without setting the domain out-parameter. If this happens, then download via a scratch GTT BO to avoid CPU VRAM read.

Re: [PATCH 1/6] DownloadFromScreenCS: download via a scratch BO if pixmap domain is unknown

2010-09-01 Thread xmail
Michel Dänzer writes: On Mit, 2010-09-01 at 10:39 +1200, Karl Tomlinson wrote: Again, the consequences of a CPU read from VRAM are much worse, I expect/hope, than the consequences of GPU blit from GTT. Maybe a GPU blit when the BO is in CPU domain would be bad, but is it likely to be busy

Re: [PATCH 1/6] DownloadFromScreenCS: download via a scratch BO if pixmap domain is unknown

2010-08-31 Thread Michel Dänzer
On Mon, 2010-08-23 at 18:27 +1200, Karl Tomlinson wrote: radeon_bo_is_busy() may return without setting the domain out-parameter. If this happens, then download via a scratch GTT BO to avoid CPU VRAM read. I'm on the fence about this one. I can see how it could help *if* radeon_bo_is_busy()

Re: [PATCH 1/6] DownloadFromScreenCS: download via a scratch BO if pixmap domain is unknown

2010-08-31 Thread Karl Tomlinson
Michel Dänzer writes: On Mon, 2010-08-23 at 18:27 +1200, Karl Tomlinson wrote: radeon_bo_is_busy() may return without setting the domain out-parameter. If this happens, then download via a scratch GTT BO to avoid CPU VRAM read. I'm on the fence about this one. I can see how it could help

[PATCH 1/6] DownloadFromScreenCS: download via a scratch BO if pixmap domain is unknown

2010-08-23 Thread Karl Tomlinson
From df63f153eb9e8ef380c7fc1f754183d646da9eba Mon Sep 17 00:00:00 2001 From: Karl Tomlinson kar...@karlt.net Date: Sat, 21 Aug 2010 21:44:39 +1200 Subject: [PATCH 1/6] DownloadFromScreenCS: download via a scratch BO if pixmap domain is unknown radeon_bo_is_busy() may return without setting the