Re: [PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read

2010-09-01 Thread Michel Dänzer
On Mit, 2010-09-01 at 10:32 +1200, Karl Tomlinson wrote: Michel Dänzer writes: @@ -593,6 +596,10 @@ RADEONDownloadFromScreenCS(PixmapPtr pSrc, int x, int y, int w, if ((src_domain (RADEON_GEM_DOMAIN_GTT | RADEON_GEM_DOMAIN_VRAM)) == (RADEON_GEM_DOMAIN_GTT |

Re: [PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read

2010-09-01 Thread xmail
Michel Dänzer writes: On Mit, 2010-09-01 at 10:32 +1200, Karl Tomlinson wrote: Note that radeon_bo_get_src_domain() returns the write domain if there is one. AFAICT it's kind of the other way around, it only returns the write domain if no read domain is specified. I'm looking at

Re: [PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read

2010-08-31 Thread Michel Dänzer
On Mon, 2010-08-23 at 19:41 +1200, Karl Tomlinson wrote: If unflushed CS operations write to the pixmap BO, then these need to be flushed before mapping the BO for read. This currently only affects big endian systems and only when the operation writes to the GTT domain. [...] @@ -593,6

Re: [PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read

2010-08-31 Thread Karl Tomlinson
Michel Dänzer writes: @@ -593,6 +596,10 @@ RADEONDownloadFromScreenCS(PixmapPtr pSrc, int x, int y, int w, if ((src_domain (RADEON_GEM_DOMAIN_GTT | RADEON_GEM_DOMAIN_VRAM)) == (RADEON_GEM_DOMAIN_GTT | RADEON_GEM_DOMAIN_VRAM)) src_domain = 0; +#if X_BYTE_ORDER ==

[PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping

2010-08-23 Thread xmail
From c486d7eb68edf3b4c7cfd59da50f30898f0b36f2 Mon Sep 17 00:00:00 2001 From: Karl Tomlinson kar...@karlt.net Date: Sun, 22 Aug 2010 20:04:42 +1200 Subject: [PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read If unflushed CS operations write to the pixmap BO

[PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read

2010-08-23 Thread Karl Tomlinson
(A subsequent patch proposes removing #if X_BYTE_ORDER.) From c486d7eb68edf3b4c7cfd59da50f30898f0b36f2 Mon Sep 17 00:00:00 2001 From: Karl Tomlinson kar...@karlt.net Date: Sun, 22 Aug 2010 20:04:42 +1200 Subject: [PATCH 3/6] RADEONDownloadFromScreenCS: flush CS writes before mapping BO for read