Re: [xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-29 Thread Lasse Collin
On 2024-02-28 Sebastian Andrzej Siewior wrote: > On 2024-02-28 18:45:03 [+0200], Lasse Collin wrote: > > V_DEBUG was commited to the master and v5.6 branches a few moments > > ago, so yes, your plan sounds good. :-) Feel free to do it as you > > prefer, either just making the change or picking the

Re: [xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-28 Thread Lasse Collin
On 2024-02-28 Sebastian Andrzej Siewior wrote: > I see. In that case let me throw this to V_DEBUG Debian wise and sync > with xz upstream once a new release is up or so. I have two packages > that fail because of this and dpkg added a workaround. So instead > adding another workaround to another

Re: [xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-28 Thread Sebastian Andrzej Siewior
On 2024-02-28 13:00:08 [+0200], Lasse Collin wrote: > > > There are also messages that are shown when memory limit does affect > > > compressed output (switching to single-threaded mode and LZMA2 > > > dictionary size adjustment). The verbosity requirement of these > > > messages isn't being

Re: [xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-28 Thread Lasse Collin
On 2024-02-27 Sebastian Andrzej Siewior wrote: > On 2024-02-27 19:17:48 [+0200], Lasse Collin wrote: > > - The silencing could be done with -q as well though. > > Wouldn't -q also shut some legitime warnings? Yes. When compressing from stdin to stdout, there aren't many possible warnings but

Re: [xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-27 Thread Sebastian Andrzej Siewior
On 2024-02-27 19:17:48 [+0200], Lasse Collin wrote: > Thanks for the patch! We discussed a bit on IRC and everyone thinks > it's on the right track but we are pondering the implementation details > still. > > The thread count messages are shown in situations which don't affect > the compressed

Re: [xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-27 Thread Lasse Collin
On 2024-02-26 Sebastian Andrzej Siewior wrote: > Print the warning about reduced threads only if number is selected > - automatically and asked to be verbose (-v) > - explicit by the user Thanks for the patch! We discussed a bit on IRC and everyone thinks it's on the right track but we are

[xz-devel] [PATCH] xz: Avoid warnings due to memlimit if threads are in auto mode.

2024-02-26 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior If threads are automatically selected then it is possible that their number needs to get reduced in order not to exceed the current memory limit. This "reducing" forces a warning which is printed on stderr to inform the user. The information is probably not