Re: [xz-devel] [PATCH] CMake: Add missing include directory when building the shared library

2020-07-12 Thread Lasse Collin
On 2020-06-04 Markus Rickert wrote: > This way also works, I just tested your patch on my system with > VS2019. The DLL includes the following info, looks good to me: > > File description: liblzma data compression library > File version: 5.3.1.0 > Product name: XZ Utils

Re: [xz-devel] [PATCH] CMake: Add missing include directory when building the shared library

2020-06-04 Thread Markus Rickert
Great to see this being tested. Thanks! Including CMake build files in the repository is very much appreciated for building on different platforms and especially on Windows. Thank you for that. The CMakeLists.txt doesn't create config.h. All #defines are set as compiler options. The

Re: [xz-devel] [PATCH] CMake: Add missing include directory when building the shared library

2020-06-04 Thread Lasse Collin
On 2020-06-02 Markus Rickert wrote: > When using CMake to build a shared library with Visual Studio 2019, I > get an error that the file config.h could not be found: > > cmake -G "Visual Studio 16 2019" -A x64 -DBUILD_SHARED_LIBS=ON ..\xz > cmake --build . --config Release > >

[xz-devel] [PATCH] CMake: Add missing include directory when building the shared library

2020-06-02 Thread Markus Rickert
When using CMake to build a shared library with Visual Studio 2019, I get an error that the file config.h could not be found: cmake -G "Visual Studio 16 2019" -A x64 -DBUILD_SHARED_LIBS=ON ..\xz cmake --build . --config Release xz\src\common\common_w32res.rc(9): fatal error RC1015: cannot open