Re: [xz-devel] [PATCH] xzdiff: Trap SIGPIPE

2021-01-11 Thread Lasse Collin
On 2021-01-11 Étienne Mollier wrote: > Lasse Collin, on 2021-01-11 19:19:09 +0200: > > I understand from your message that you got a different result. I > > wonder what would explain the difference. Your results are close to > > what I would expect with the "trap '' PIPE" patch. Are you sure you >

Re: [xz-devel] [PATCH] xzdiff: Trap SIGPIPE

2021-01-11 Thread Étienne Mollier
Hello, Lasse Collin, on 2021-01-11 19:19:09 +0200: > Since xz-devel is subscribers only, I quote your message in full and > also include your test scripts as an attachment for others to see. Thanks for the notice, I subscribed for convenience. > I understand from your message that you got a

Re: [xz-devel] [PATCH] xzdiff: Trap SIGPIPE

2021-01-11 Thread Lasse Collin
Hello! Since xz-devel is subscribers only, I quote your message in full and also include your test scripts as an attachment for others to see. On 2021-01-09 Étienne Mollier wrote: > Lasse Collin, on 2021-01-09 17:38:20 +0200: > > The following patch replace -cdfq with -cdf and ignores

Re: [xz-devel] [PATCH] xzdiff: Trap SIGPIPE

2021-01-09 Thread Lasse Collin
On 2021-01-08 Lasse Collin wrote: > It's tempting to ignore exit statuses >= 128 at the end of the script > where it current checks for "$xz_status" -eq 0 but that doesn't work > because in the middle of the script there is also this: > > case $xz_status in > *[1-9]*)

Re: [xz-devel] [PATCH] xzdiff: Trap SIGPIPE

2021-01-08 Thread Lasse Collin
On 2020-12-24 Sebastian Andrzej Siewior wrote: > The `cmp' command will return early if a difference is found while the > shell script is still invoking the decompressor which writes into the > closed FD. This results in SIGPIPE / exit code 141. > By ignoring SIGPIPE the real return code from