Re: [zones-discuss] native p2v code review

2009-02-01 Thread Peter Memishian
Thanks for looking at this. I'll take a look at each of your recommendations. One factor is that we plan on backporting this to S10, so I want to keep things working on that release with a minimum of changes. Erm... the warnings returned by $ ksh93 -n scriptname # apply to

Re: [zones-discuss] native p2v code review

2009-01-21 Thread Jerry Jelinek
Roland, Thanks for looking at this. I'll take a look at each of your recommendations. One factor is that we plan on backporting this to S10, so I want to keep things working on that release with a minimum of changes. Thanks again, Jerry ___

Re: [zones-discuss] native p2v code review

2009-01-21 Thread Jerry Jelinek
Mike, Thanks for reviewing this and sending your comments. I'll make the changes to use mktemp. Responses to your other comments are in-line. Mike Gerdts wrote: /usr/src/lib/brand/native/zone/image_install.ksh 290 typeset line=$(grep files_compressed_method $ident) 301

[zones-discuss] native p2v code review

2009-01-20 Thread Jerry Jelinek
I have a first cut at p2v for native zones. This is: 6667924 physical to virtual utility for native zones PSARC 2008/766 native zones p2v There is a webrev at: http://cr.opensolaris.org/~gjelinek/webrev.p2v/ I already have some comments from Ed and I'll be making a few small changes, but I'd

Re: [zones-discuss] native p2v code review

2009-01-20 Thread Roland Mainz
Jerry Jelinek wrote: I have a first cut at p2v for native zones. This is: 6667924 physical to virtual utility for native zones PSARC 2008/766 native zones p2v There is a webrev at: http://cr.opensolaris.org/~gjelinek/webrev.p2v/ Quick look at

Re: [zones-discuss] native p2v code review

2009-01-20 Thread Mike Gerdts
On Tue, Jan 20, 2009 at 6:33 PM, Jerry Jelinek gerald.jeli...@sun.com wrote: I have a first cut at p2v for native zones. This is: 6667924 physical to virtual utility for native zones PSARC 2008/766 native zones p2v There is a webrev at: http://cr.opensolaris.org/~gjelinek/webrev.p2v/ I