Review Request: ZOOKEEPER-823

2010-09-08 Thread Thomas Koch
Hi Ben, Mahadev, Patrick suggested I might ask you for review on ZOOKEEPER-823. It does some refactoring on ClientCnxn and blocks other issues which also want to edit ClientCnxn. Thanks, Thomas Koch, http://www.koch.ro

Re: Review Request: ZOOKEEPER-823

2010-09-08 Thread Mahadev Konar
Hi Thomas, I do have that on my list. I probably will be doing it by this weekend for sure. Thanks mahadev On 9/8/10 9:16 AM, Thomas Koch tho...@koch.ro wrote: Hi Ben, Mahadev, Patrick suggested I might ask you for review on ZOOKEEPER-823. It does some refactoring on ClientCnxn and

Re: Review Request: ZOOKEEPER-823

2010-09-08 Thread Mahadev Konar
I just reviewed the patch. You can go ahead and commit it. I am going to run the ant test now. Thanks mahadev On 9/8/10 9:23 AM, Patrick Hunt ph...@apache.org wrote: Hudson trunk is currently failing due to some fd cleanup issue. Not sure if I introduced that recently with the netty server