The fix looks good. All tests pass including the one that reproduced the problem. I
have checked-it-in.
Thanks,
Vishal
Raul Benito wrote:
>
> Vishal Mahajan wrote:
>
> >Attached is the testcase that shows the problem. I'll check-in the test into the
> >workspace later.
> >
> >Vishal
> >
> >Berin Lautenbach wrote:
> >
> >
> >>Vishal,
> >>
> >>Not good! Be interested to see what Raul comes back with. Either way
> >>it would be great to have a test case in the interop tests that can
> >>replicate the problem.
> >>
> >>Cheers,
> >> Berin
> >>
> >>
> >>
> Here ia a little fix for this error.
>
> Index: XMLUtils.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-security/src/org/apache/xml/security/utils/XMLUtils.java,v
> retrieving revision 1.36
> diff -u -r1.36 XMLUtils.java
> --- XMLUtils.java 12 May 2004 12:00:46 -0000 1.36
> +++ XMLUtils.java 22 Jun 2004 17:04:17 -0000
> @@ -87,11 +87,20 @@
> result.add(nl.item(i));
> }
> case Node.DOCUMENT_NODE:
> + boolean skipingTextNodes=false;
> Node r=rootNode.getFirstChild();
> if (r==null) {
> break;
> }
> do {
> + if (r.getNodeType()==Node.TEXT_NODE) {
> + if (skipingTextNodes) {
> + continue;
> + }
> + skipingTextNodes=true;
> + } else {
> + skipingTextNodes=false;
> + }
> getSet(r,result,com);
> } while ((r=r.getNextSibling())!=null);
> break;
