Signature verification fails due to Java object reference mismatch in ElementProxy#guaranteeThatElementInCorrectSpace()

[Ruchith Fernando]

Hi Devs,

ElementProxy#guaranteeThatElementInCorrectSpace() method contains the
following check :

   if ((namespaceSHOULDBE!=namespaceIS) ||
      !localnameSHOULDBE.equals(localnameIS) ) {
        Object exArgs[] = { namespaceIS +":"+ localnameIS,
          namespaceSHOULDBE +":"+ localnameSHOULDBE};
        throw new XMLSecurityException("xml.WrongElement", exArgs);
     }

I'm using opensaml-1.1b and I encounter a signature failure  due to
namespaceIS  object not being the same object as namespaceSHOULDBE. Is
this intentional (Apologies if I overlooked something obvious)? Or can
we change this to the following:

     if (!namespaceSHOULDBE.equals(namespaceIS)) ||
      !localnameSHOULDBE.equals(localnameIS) ) {
        Object exArgs[] = { namespaceIS +":"+ localnameIS,
          namespaceSHOULDBE +":"+ localnameSHOULDBE};
        throw new XMLSecurityException("xml.WrongElement", exArgs);
     }

Thanks,
Ruchith