[ 
https://issues.apache.org/jira/browse/JAMES-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898614#action_12898614
 ] 

Stefano Bagnara commented on JAMES-1035:
----------------------------------------

IIRC implementing DomainList  was a need in order to configure James with 
JDBCVirtualUserTable and still use the same bean also for the server domain 
list. This way you have a single db table for users and domains are "computed" 
from enlisted rules.

I'm not suggesting we should revert this commit, just explaining how it worked!

I'm not up to date with the current trunk, so maybe now we have a smarter way 
to manage multi domain virtual user tables and domains without the need to 
reconfigure/restart james: in this case maybe we should add at least a comment 
here on how to do that now.

> XML/JDBCVirtualUserTable should not implement DomainList
> --------------------------------------------------------
>
>                 Key: JAMES-1035
>                 URL: https://issues.apache.org/jira/browse/JAMES-1035
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: James Core
>    Affects Versions: Trunk
>            Reporter: Eric Charles
>            Assignee: Eric Charles
>             Fix For: 3.0-M1
>
>
> VirtualUserTable (AbstractVirtualUserTable and its implementations) 
> implements DomainList but should not be related to the domain management.
> We should remove "implements DomainList" and its implementation methods.
> We should also remove the mentions in spring-beans.xml as possible 
> "domainlist" bean. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to