On Fri, 15 Dec 2023 07:20:47 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1187:
>
>> 1185: fread(buffer, 1, LDHDRSZ_64, f);
>> 1186: memcpy((char*)&ldr64, buffer, LDHDRSZ_64);
>> 1187: fseek (f, scn64.s_scnptr + ldr64.l_impoff, SEEK_SET);
>
> nit: please use consistent spacing according to hotspot rules. here, remove
> space.
Do you mean the space `fseek (` ?
Done.
> src/hotspot/os/aix/os_aix.cpp line 1191:
>
>> 1189: }
>> 1190: else
>> 1191: buffer[0] = 0;
>
> {}
Done, due to complete rewriting. s.o.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1427869786
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1427870433
