On Fri, 10 May 2024 09:06:08 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> MEMFLAGS, as well as its enum constants, should live in its own include. > > The constants are used throughout the code base, often without needing the > allocation APIs exposed through allocation.hpp. > > The MEMFLAGS enum def is often needed within NMT itself, again often without > needing allocation.hpp. > > --- > > This patch moves the enum to its new file. > > It fixes those `allocation.hpp` includes that where only needed to get > MEMFLAGS. It does not fix other includes. > > For backward compatibility, until we straightened out the dependencies (e.g., > fixing all places where we rely on indirect includes), I added memflags.hpp > to allocation.hpp. > > I tested (built) on: > - MacOS aarch64, no precompiled headers, fastdebug > - Linux x64, no precompiled headers, fastdebug, release, fastdebug crossbuild > to aarch64, fastdebug minimal Ping @afshin-zafari @jdksjolen @gerard-ziemski ------------- PR Comment: https://git.openjdk.org/jdk/pull/19172#issuecomment-2104357678
