On 26.03.20 02:12, Maxim Levitsky wrote: > The recent patches from Max Reitz allowed some block drivers to not > provide the .bdrv_co_create_opts and still allow qemu-img to > create/format images as long as the image is already existing > (that is the case with various block storage drivers like nbd/iscsi/nvme, etc) > > However it was found out that some places in the code depend on the > .bdrv_co_create_opts/.create_opts to be != NULL to decide if to allow > image creation. > > To avoid adding failback code to all these places, just make generic failback > code be used by the drivers that need it, so that for outside user, there > is no diffirence if failback was used or not. > > Best regards, > Maxim Levitsky > > Maxim Levitsky (2): > block: pass BlockDriver reference to the .bdrv_co_create > block: trickle down the fallback image creation function use to the > block drivers
Thanks, fixed the function parameter alignment, moved the declarations from block.h into block_int.h, and applied the series to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max
signature.asc
Description: OpenPGP digital signature
-- sheepdog mailing list sheepdog@lists.wpkg.org https://lists.wpkg.org/mailman/listinfo/sheepdog
