On Thu, Oct 23, 2003 at 02:33:16PM -0700, Kees Cook wrote: > Well, I've read through the developer guide, and dug around in the > Makefile, etc. The one thing about the "imagemanip" tool is that it has a > setuid wrapper (so that non-root users can work on the images). Since > nothing is compiled right now in SystemImager, where would people > suggestion I put the wrapper source? I also figure that other people > should take a close look at the wrapper and perl code before it gets > included "by default" in the build/install process. > > My current pending changes/adds look like this: > > ? etc/imagemanip.conf > ? etc/imagemanip.perm > ? lib/imagemanip > ? lib/imagemanip.c > ? tools/README > M CHANGE.LOG > M CREDITS > M Makefile > M doc/man/Makefile > > I didn't want to commit the changes until someone else more familiar with > the development process at least looked over my shoulder. :)
well, since you're adding new files, its good to discuss where they should go first. assuming imagemanip is the executable, it might make sense to put it in sbin/ instead of lib/. It may even make sense just to have an imagemanip directory of your own. either as a top level module, or in the systemimager module - especially considering that a compiled program will need to be delivered separately, since it needs to be rebuilt on every architecture. (iow, this wouldn't be in the systemimager-server packages). suid binaries are scary things... can you talk about why you chose to implement it this way, as opposed to giving users restrictive sudo perms, etc? thanks Kees! ------------------------------------------------------- This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/ _______________________________________________ Sisuite-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/sisuite-devel
