Bernard Li wrote:
> For now I have put "bittorrent" in OSCAR's base prereqs, meaning that
> the package will be installed prior to SIS being installed.  This is
> not ideal (IMHO) but does work.
>
> If nobody from OSCAR objects, I will leave it at that.
>
> Basically the issue is that in SystemImager 3.7.6, bittorrent RPM
> dependency was removed such that RPMs can be distro-neutral (SuSE
> calls it BitTorrent, RH/FC calls it bittorrent).  There is also a
> check for bittorrent binaries in the %pre script, if it couldn't find
> them the installation of systemimager-bittorrent would fail.  This
> can't be bypassed simply by adding bittorrent to SIS' config.xml,
> since there is no ordering involved.

OK, I like to replace the exit statement with a warning (instead of
error) directly in systemimager-bittorrent package, but I think that
also this change is needed in OSCAR, to remove warning message that
could generate confusion to the users...

What do you think about this?

-Andrea

Index: systemimager.spec
===================================================================
--- systemimager.spec   (revision 3896)
+++ systemimager.spec   (working copy)
@@ -774,29 +774,29 @@
 echo "checking for a tracker binary..."
 BT_TRACKER_BIN=`(which bittorrent-tracker || which bttrack) 2>/dev/null`
 if [ -z $BT_TRACKER_BIN ]; then
-       echo "error: couldn't find a valid tracker binary!"
+       echo "WARNING: couldn't find a valid tracker binary!"
        echo "--> Install the BitTorrent package (bittorrent for RH)."
-       exit 1
+else
+       echo done
 fi
-echo done

 echo "checking for a maketorrent binary..."
 BT_MAKETORRENT_BIN=`(which maketorrent-console || which btmaketorrent)
2>/dev/null`
 if [ -z $BT_MAKETORRENT_BIN ]; then
-       echo "error: couldn't find a valid maketorrent binary!"
+       echo "WARNING: couldn't find a valid maketorrent binary!"
        echo "--> Install the BitTorrent package (bittorrent for RH)."
-       exit 1
+else
+       echo done
 fi
-echo done

 echo "checking for a bittorrent binary..."
 BT_BITTORRENT_BIN=`(which launchmany-console || which btlaunchmany)
2>/dev/null`
 if [ -z $BT_BITTORRENT_BIN ]; then
-       echo "error: couldn't find a valid bittorrent binary!"
+       echo "WARNING: couldn't find a valid bittorrent binary!"
        echo "--> Install the BitTorrent package (bittorrent for RH)."
-       exit 1
+else
+       echo done
 fi
-echo done

 %preun bittorrent
 if [ $1 = 0 ]; then


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
sisuite-devel mailing list
sisuite-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sisuite-devel

Reply via email to