Erich Focht wrote:
> Hi Andrea,
>
> On Monday 10 September 2007 19:23, [EMAIL PROTECTED] wrote:
>> Author: arighi
>> Date: 2007-09-10 12:23:47 -0500 (Mon, 10 Sep 2007)
>> New Revision: 4278
>>
>> Modified:
>> trunk/etc/autoinstallscript.template
>> trunk/lib/SystemImager/Server.pm
>> Log:
>> - fix: replace the device names in the systemconfigurator config file
>> according to the systemimager configuration and use systemconfigurator to
>> re-create the boot-loader config
>>
>> This allows to totally redefine the partitioning schema in
>> autoinstallscript.conf and automatically fix the boot-loader configuration,
>> for
>> example moving from a non-UUID/LABEL to a UUID/LABEL based naming schema, or
>> splitting the root partition into two different partitions "/" and "/boot",
>> etc.
>>
>>
>> Modified: trunk/etc/autoinstallscript.template
>> ===================================================================
>> --- trunk/etc/autoinstallscript.template 2007-09-10 14:12:43 UTC (rev
>> 4277)
>> +++ trunk/etc/autoinstallscript.template 2007-09-10 17:23:47 UTC (rev
>> 4278)
>> @@ -1837,6 +1863,8 @@
>> print $out "NETMASK = \$NETMASK\n";
>> }
>>
>> + print $out "\n\$(test -e $sc_conf_file && cat $sc_conf_file)\n";
>> +
>> print $out "EOL\n";
>> }
>
> This one is evil and unneeded. SC is reloading the
> /etc/systemconfig/systemconfig.conf andway, you don't need to copy it into the
> input stream. The problem is: the variables outside the block definitions are
> treated as if they belong to the [INTERFACE0] block and SC punts.
>
> I'll remove it, but wanted to make sure you know it's a problem!
>
Hi Erich,
Good catch! I supposed --stdin excluded the configurations defined in
/etc/systemconfig/systemconfig.conf, but, looking at the SC source it seems that
you're totally right. From lib/SCConfig.pm:
---
my @args;
if(-e "/etc/systemconfig/systemconfig.conf") {
push @args, qw(/etc/systemconfig/systemconfig.conf);
}
if($config->stdin()) {
push @args, \*STDIN;
}
---
Please fix the autoinstallscript.template in trunk.
Thanks,
-Andrea
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
sisuite-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sisuite-devel
