Hello again :-) I found an inconsistency in /usr/lib/systemimager/perl/SystemImager/Server.pm
In the function validate_ip_assignment_option the variable
ip_assignment_method is mapped to lowercase letters before
usage/comparison, which works just fine.
In write_sc_command_pre and write_sc_command_pos on the other hand
ip_assignment_method is used without running "lc" first.
For me this had the following impact:
Using "--ip-assignment STATIC" passes the validation, as the comparison
to its lowercase equivalent "static" succeeds, but systemconfigurator is
called with an incomplete configuration, as the following block is just
skipped in write_sc_command_post:
elsif ($ip_assignment_method eq "static") {
print $out "TYPE = static\n";
print $out "IPADDR = \$IPADDR\n";
print $out "NETMASK = \$NETMASK\n";
}
[using "--ip-assignment static" works as expected]
ip_assignment_method should either always be mapped to lc before
comparison to reference strings, or may be it is even reasonable to
convert the command line parameter to lc right after options parsing [in
si_getimage] and before the parameter is passed on to any functions [in
this case the lc in the validation should be removed]
Still using v4.1.6 of SystemImager
Cheers
Daniel
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ sisuite-devel mailing list sisuite-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sisuite-devel
