Hi Thomas:
On Tue, Apr 5, 2011 at 12:41 PM, Thomas Zeiser
<[email protected]> wrote:
> attached are three small patches to improve compatibility with
> OpenSuSE 11.3:
> - allow parted version numbers "a.b" in addition to "a.b.c"
> - avoid non-initialized variable in si_getimage
> - detect date format of OpenSuSE 11.3 kernels for UYOK
Thanks for your patches.
Regarding the change to si_getimage, perhaps this is a better patch?
Index: sbin/si_getimage
===================================================================
--- sbin/si_getimage (revision 4535)
+++ sbin/si_getimage (working copy)
@@ -136,7 +136,9 @@
"quiet" => \$quiet
) || die "$help_info";
-$update_script = lc $update_script;
+if ($update_script) {
+ $update_script = lc $update_script;
+}
#if requested, print help information
if ($help) {
@@ -196,8 +198,7 @@
# be sure $update_script was passed a proper option
unless(
- ($update_script eq "" )
- or ($update_script eq "yes")
+ ($update_script eq "yes")
or ($update_script eq "no" )
) { die "\n$program_name: --update-script must be yes or no.\n$get_help\n\n"; }
I do not like setting $update_script to "no" since that is not the
default (it is perfectly fine not to define $update_script).
I also disallowed $update_script to be "" since that doesn't make
sense -- Brian?
Cheers,
Bernard
------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
sisuite-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sisuite-users
