On 04/01/11 13:59, Ilia Barahovski wrote: > Hi, > > In the latest version of soci some old bug is back. Somebody commented > out part of the patch I sent you before
I commented it http://soci.git.sourceforge.net/git/gitweb.cgi?p=soci/soci;a=commit;h=6da1388f950c049d257a8bdd0612c30656bd9dbb > Problematic lines are in the > file type-conversion.h in 4 constructors of the conversion_use_type > class. The patch was to call convert_to_base() function from all the > constructors. Unfortunately, this is unacceptable change in such form. It leads to duplicate the call leading to more problems that it solves Here are related discussions: https://sourceforge.net/mailarchive/message.php?msg_id=26780260 https://sourceforge.net/mailarchive/message.php?msg_id=26781775 > The patch do cause some problems for the following reason: > convert_to_base() is called twice, first from the constructor mentioned, > then from the standard_use_type::pre_use() function. Under assumption, > that convert_to_base() doesn’t have side effects, the patch effect is > time overhead only. As explained above, it causes serious problems. > What the patch fixes is an obscure bag that happens in the following case: > [...] I'm replying in rush now, but will check those details later. > Trustfully the correct solution is to call the pre_use() before calling > to define_and_bind() instead of from execute(). But this may conflict > with other backends, so I proposed a less clean solution that should > break nothing else but creates an overhead. The problem is that it breaks other backends. I'm not eager to manipulate the core architecture at this stage. Unfortunately, I'm having very busy January now and even struggling to finish final testing and release new version. So, I can't promise any motion regarding your issue. p.s. I've added CC to Maciej, perhaps he will find a quick solution. I've also CC'ed to soci-users. Ilia, I'd suggest to continue discussing this issue on the mailing list, if you don't mind. There are users and developers interested in it. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org Member of ACCU, http://accu.org ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users
