On Fri, Sep 28, 2012 at 11:12 AM, Mateusz Loskot <[email protected]> wrote:
> On 28 September 2012 07:36, Pawel Aleksander Fedorynski
> <[email protected]> wrote:
> > On Fri, Sep 28, 2012 at 2:26 AM, Mateusz Loskot <[email protected]>
> wrote:
> >>
> >> Pawel, here is another patch for MySQL which I'm not sure what to do
> >> about.
> >> Could you have a look, please?
> >
> > Link?
>
>
> Sorry, I forgot.
> Here it is https://github.com/SOCI/soci/pull/3
Thanks. I added some comments using the github interface, basically two
comments
1. Make the indentation consistent with the rest of the file
2. Don't change the default behavior wrt the reconnect functionality, make
it a connect string option instead.
Other than that looks good.
Thanks,
Aleksander
>
>
> Best regards,
> --
> Mateusz Loskot, http://mateusz.loskot.net
>
>
> ------------------------------------------------------------------------------
> Got visibility?
> Most devs has no idea what their production app looks like.
> Find out how fast your code is with AppDynamics Lite.
> http://ad.doubleclick.net/clk;262219671;13503038;y?
> http://info.appdynamics.com/FreeJavaPerformanceDownload.html
> _______________________________________________
> Soci-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/soci-users
>
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Soci-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/soci-users
