On Fri, 22 Mar 2013 14:18:55 +0000 Mateusz Loskot <[email protected]> wrote:
ML> I'd prefer to complete the release this weekend OK, when exactly are you going to do it? I'll try to add the tests this evening but I'm not sure if I'm going to be able to finish this, so if you do it on Sunday I'd try to finish them tomorrow. ML> I assume that you have tested the fixes Yes, our code does exercise these fixes. ML> If you say we can release without the tests added, just with the ML> fixes, let's do so. The "endOfRowSet" fix is perfectly safe to apply, it can't break anything because it changes nothing if execute() is called only once and if it's called twice or more times, currently it doesn't work at all so anything else can only be an improvement. The "s/unsigned/int/" fix for SQL_LONG is slightly more risky but, still, right now you simply get completely wrong values when reading from the database (something like 4953.956 when the database contains -0.0013), so IMO it would still be better to apply it rather than not do it because silently reading wrong data is one of the worst things that can happen in a database library. ML> Are you OK with releasing your fixes but without tests in 3.2.0? I prefer to commit them without tests to not committing them at all but I'll try to add the tests too. Just please let me know until when do I have to do this. TIA, VZ
pgpRoruElxouW.pgp
Description: PGP signature
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________ soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users
