[
https://issues.apache.org/jira/browse/SOLR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Hatcher updated SOLR-79:
-----------------------------
Attachment: solr-config-system-property.patch
Updated the patch per Hoss' feedback. Specifically:
i haven't tested Erik's patch, but it reads clean to me.
a couple of minor nits...
1) Javadoc: done.
2) Hoss: if the system properties used were "solr.test.sys.prop1", etc. the
patch wouldn't need to modify build.xml ... if we are going to set them
explicitly in build.xml, there shold be a comment explaining which test uses
them. [Erik: I don't understand... are you saying there is a predefined
solr.test.sys.prop1 somewhere? I didn't spot anything like that, so I've kept
with defining a couple of test ones in build.xml
3) ye of little faith! the doc that the Config object holds has been
modified recursively, so all methods querying the doc will see the substituted
values. I've added a test to show the case you mentioned.
4) I added similar tests for .evaluate and .getNode. All is well.
> [PATCH] Using system properties in Solr configuration
> -----------------------------------------------------
>
> Key: SOLR-79
> URL: https://issues.apache.org/jira/browse/SOLR-79
> Project: Solr
> Issue Type: New Feature
> Reporter: Alexander Saar
> Assigned To: Erik Hatcher
> Priority: Minor
> Attachments: solr-config-system-property.patch,
> solr-config-system-property.patch, solr-config-system-property.patch,
> solr-config-system-property.patch, solr-config-system-property.patch,
> solr-config-system-property.patch
>
>
> Actually it is not possible to use system properties for configuring the Solr
> engine. There should be a way of referencing system properties from
> solrconfig.xml, like {$prop.name}.
> The attached patch will provide this feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
