Any thoughts on adding the svn version info to the manifest Implementation-Version?

currently, the ant task sets something that looks like:
Implementation-Version: 1.3-dev - ryan - 2007-06-03 12:49:52

It would be nice to have:
Implementation-Version: 1.3-dev 543971M - ryan - 2007-06-03 12:49:52

The one *major* problem with this is that MANIFEST.MF has a max line length of 70... if you have a login name longer then 7 (bdelacretaz) it wraps to the next line. If we remove the time, then we are fine also.
Implementation-Version: 1.3-dev 543971M - bdelacretaz- 2007-06-03

For me, the repos version is way more useful then the build time, so I think its a good trade off.

This works for my local build.xml:

<exec dir="." executable="svnversion" outputproperty="svnversion"
 failifexecutionfails="false">
  <arg line="."/>
</exec>
...
<attribute name="Implementation-Version"
           value="${version} ${svnversion} - ${user.name} - ${DSTAMP}"/>


thoughts?
ryan

Reply via email to