[
https://issues.apache.org/jira/browse/SOLR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509916
]
Hoss Man commented on SOLR-260:
-------------------------------
> Where do you think is the best place? the example solrconfig.xml?
well, at a minimum we should change it to use default="true" and document what
that means, removing the comment about "standard" from there would probably
make sense since new users aren't going to care about the magic of hte name
"standard" with the default=true syntax .. but we should still document on the
wiki somewhere what the full handler/writer resolution chain is.
> The RequestHandler funny business with lazy loading makes it better to
> directly subclass AbstractPluginLoader
...ah, yeah i missed that ... but i don't see any reason why it can't still
subclass NamedListPluginLoader just for the init method (even if it is does
need custom create/register methods.
> reusable PluginLoader -- helper class to load plugins
> -----------------------------------------------------
>
> Key: SOLR-260
> URL: https://issues.apache.org/jira/browse/SOLR-260
> Project: Solr
> Issue Type: New Feature
> Reporter: Ryan McKinley
> Attachments: SOLR-260-PluginLoader.patch, SOLR-260-PluginLoader.patch
>
>
> As we talk about adding more configuration (Handlers, Highlighting,
> Components, etc) we should standardize the format and share the loading and
> initialization code.
> This patch extracts the common stuff from SOLR-225 and makes it work with the
> RequestHandler framework.
> This is an abstract base class -- each implementation needs to take care of
> actually creating and initializing the instances:
> abstract class PluginLoader<T>
> {
> abstract public T create( String className, NamedList args,
> Map<String,String> params );
>
> abstract public void init( T plugin, NamedList args, Map<String,String>
> params );
>
> public Map<String,T> load( NodeList nodes )
> {
> ...
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
