[
https://issues.apache.org/jira/browse/SOLR-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616600#action_12616600
]
Hoss Man commented on SOLR-489:
-------------------------------
Reading through Lars's patch, most everything looks fine to me, except...
1) javadoc generates a lot of warnings like this...
{noformat}
[javadoc]
/home/chrish/lucene/solr/src/java/org/apache/solr/request/SolrQueryRequest.java:107:
warning - Tag @link: reference not found: CommonParams#ROWS
[javadoc]
/home/chrish/lucene/solr/src/java/org/apache/solr/request/SolrQueryRequest.java:87:
warning - Tag @link: reference not found: CommonParams#Q
[javadoc]
/home/chrish/lucene/solr/src/java/org/apache/solr/request/SolrQueryRequest.java:95:
warning - Tag @link: reference not found: CommonParams#QT
...
{noformat}
...i think that's just a missing import that we need (didnt' check though)
2) i'm not really sure about the new isOverwrite() method added to
client/java/solrj/src/org/apache/solr/client/solrj/request/UpdateRequest.java
...
is adding this method the right course of action? what as the intention when
deprecating isOverwriteCommitted() and isOverwritePending().
For that matter: solrJ wasn't in Solr 1.2 ... can't we just outright remove any
"@Deprecated" methods from that code?
> Added @deprecation Javadoc comments
> -----------------------------------
>
> Key: SOLR-489
> URL: https://issues.apache.org/jira/browse/SOLR-489
> Project: Solr
> Issue Type: Bug
> Components: documentation
> Reporter: Sean Timm
> Assignee: Mike Klaas
> Priority: Trivial
> Fix For: 1.3
>
> Attachments: deprecationDocumentation.patch, SOLR-489.patch
>
>
> In a number of files, @Deprecation annotations were added without
> accompanying @deprecation Javadoc comments to explain what to use now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
