[ 
https://issues.apache.org/jira/browse/SOLR-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar resolved SOLR-1035.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
         Assignee: Shalin Shekhar Mangar

Committed revision 747284.

Thanks David!

> catch RuntimeException instead of NFE in FieldType line 187
> -----------------------------------------------------------
>
>                 Key: SOLR-1035
>                 URL: https://issues.apache.org/jira/browse/SOLR-1035
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: David Smiley
>            Assignee: Shalin Shekhar Mangar
>            Priority: Trivial
>             Fix For: 1.4
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> This is a super-easy request for a Solr commiter to do.  Look at line 187 of 
> FieldType.  It catches NumberFormatException (a subtype of RuntimeException) 
> when calling toInternal() in order to throw a SolrException that has useful 
> information -- namely the field attempting to be set and its value.  The 
> caught exception should be declared to be very broudly at RuntimeException 
> since problems other than NumberFormatException might occur.  An example is 
> SolrException thrown by DateField when parsing fails. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to