On Thu, Mar 12, 2009 at 3:15 AM, Chris Hostetter <[email protected]>wrote:
> > I don't think treating "*" as special is something FieldType (or > TrieField) should do -- that's specific to the syntax of the QueryParser. > The FieldType classes should treat the string as a string. (otherwise if i > write a new QueryParser where * isn't a special character and use some > syntax like "phoneNumber < *69" i'm screwed. > "*69" as the > > I also think having a single "inclusive" boolean is a bad idea. > > I would javadoc that the lower/upper bounds can be null, and have > SolrQueryParser pass null when it sees "*" in the syntax. we should also > be explicit in the javadocs about what combinations of inclusion booleans > and null values are allowed so that subclasses know what to expect > Agree on all points. I'll give a fix. -- Regards, Shalin Shekhar Mangar.
