[ 
https://issues.apache.org/jira/browse/SOLR-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754337#action_12754337
 ] 

Hoss Man commented on SOLR-756:
-------------------------------

at this stage in the process for 1.4, i think most committers are focusing on 
bug fixes and avoiding adding new features ... especially new features that 
have been added to existing functionality, so they could trigger new bugs in 
*existing* use cases.

FWIW: 
* the patch doesn't seem to have any test cases demonstrating the new 
functionality, which makes me leary of committing
* i'm not certain just from skimming the patch, but it seems like this should 
break behavior for any existing users of DisjunctionMaxQueryParser who are 
expecting the field aliases to only affect getFieldQuery ... i could be wrong 
about that though.


> Make DisjunctionMaxQueryParser generally useful by supporting all query types.
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-756
>                 URL: https://issues.apache.org/jira/browse/SOLR-756
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: David Smiley
>             Fix For: 1.5
>
>         Attachments: SolrPluginUtilsDisMax.patch
>
>
> This is an enhancement to the DisjunctionMaxQueryParser to work on all the 
> query variants such as wildcard, prefix, and fuzzy queries, and to support 
> working in "AND" scenarios that are not processed by the min-should-match 
> DisMax QParser. This was not in Solr already because DisMax was only used for 
> a very limited syntax that didn't use those features. In my opinion, this 
> makes a more suitable base parser for general use because unlike the 
> Lucene/Solr parser, this one supports multiple default fields whereas other 
> ones (say Yonik's {!prefix} one for example, can't do dismax). The notion of 
> a single default field is antiquated and a technical under-the-hood detail of 
> Lucene that I think Solr should shield the user from by on-the-fly using a 
> DisMax when multiple fields are used. 
> (patch to be attached soon)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to