Is there a neighborhood of existing tests I should be visiting here?
On Fri, Jan 10, 2014 at 11:27 AM, Benson Margulies <bimargul...@gmail.com> wrote: > OK, patch forthcoming. > > On Fri, Jan 10, 2014 at 11:23 AM, Chris Hostetter > <hossman_luc...@fucit.org> wrote: >> >> : The problem manifests as this sort of thing: >> : >> : Jan 3, 2014 6:05:33 PM org.apache.solr.common.SolrException log >> : SEVERE: java.lang.IllegalArgumentException: startOffset must be >> : non-negative, and endOffset must be >= startOffset, >> : startOffset=-1811581632,endOffset=-1811581632 >> >> Is there a stack trace in the log to go along with that? there should be. >> >> My suspicion is that since analysis errors like these are >> RuntimeExceptions, they may not be getting caught & re-thrown with as much >> context as they should -- so by the time they get logged (or returned to >> the client) there isn't any info about the problematic field value, let >> alone the unqiueKey. >> >> If we had a test case that reproduces (ie: with a mock tokenfilter that >> always throws a RuntimeException when a token matches "fail_now" or >> something) we could have some tests that assert indexing a doc with that >> token results in a useful error -- which should help ensure that useful >> error also gets logged (although i don't think we don't really have any >> easy way of asserting specific log messages at the moment) >> >> >> -Hoss >> http://www.lucidworks.com/
