on Tuesday 08 March 2011 Miroslav Suchý wrote:
> > 0002-update-database-to-support-SUSE-distributions.patch
> > update the database with a SUSE breed to make "SUSE" an option for a
> > "kickstartable tree"
>
> You need to add this INSERT to
> schema/spacewalk/common/data/rhnKSInstallType.sql
> as well.
yes, you are right. I forgot to attach the patch. here it comes
> > 0004-bnc-664915-rhnreg_ks-help-failed-if-LANG-de_DE.UTF-8.patch
> > nothing kickstart related but rhnreg_ks crashed with LANG=de_DE.UTF8 when
> > you called it with "--help"
>
> BNC is not public. Can you please either
> - clone it to bugzilla.redhat.com Other->Spacewalk and refer to this bz
> number
> - or make BNC 664915
okay, I created a red hat bugzilla entry and changed the patch.
https://bugzilla.redhat.com/show_bug.cgi?id=683546
New version of the patch is attached.
> Honestly I'm confused from this one. I do not know what is root of
> cause? And what is wrong on
> _ = gettext.gettext
> We use it on a lot of places. So if there is some problem we may want to
> change it everywhere in code as well.
to be honest, I'm not a python expert. I extracted that patch from another bug
that has exactly the same failure (nothing spacewalk related) and was fixed
like that.
> BTW, when our commit address some traceback we put the traceback to
> description as it very often explain everything. For example commit
> 3612ebb308e43497ab380464f2d197e591579396
>
> It will be fine, if you can do it as well.
sure, okay.
--
ciao, Uwe Gansert
Uwe Gansert
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Business: http://www.suse.de/~ug
commit 843146b2de77899ebb44b39725a50666c30c3835
Author: Uwe Gansert <u...@suse.de>
Date: Fri Nov 5 15:34:10 2010 +0100
suse breed added to ksinstalltype
diff --git a/schema/spacewalk/common/data/rhnKSInstallType.sql b/schema/spacewalk/common/data/rhnKSInstallType.sql
index 6657e20..5394521 100644
--- a/schema/spacewalk/common/data/rhnKSInstallType.sql
+++ b/schema/spacewalk/common/data/rhnKSInstallType.sql
@@ -46,4 +46,8 @@ insert into rhnKSInstallType (id, label, name)
values (sequence_nextval('rhn_ksinstalltype_id_seq'),
'generic_rpm','Generic RPM'
);
+insert into rhnKSInstallType (id, label, name)
+ values (sequence_nextval('rhn_ksinstalltype_id_seq'),
+ 'suse','SUSE Linux'
+ );
commit;
From 52dc10f83aa3c5e3d27a9cb8dad5df15ac67b562 Mon Sep 17 00:00:00 2001
From: Uwe Gansert <u...@suse.de>
Date: Tue, 18 Jan 2011 11:46:57 +0100
Subject: [PATCH 4/5] bnc#664915 rhnreg_ks --help failed if LANG = de_DE.UTF-8
---
client/rhel/rhn-client-tools/src/bin/rhnreg_ks.py | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/client/rhel/rhn-client-tools/src/bin/rhnreg_ks.py b/client/rhel/rhn-client-tools/src/bin/rhnreg_ks.py
index e1b6c4d..e713b93 100755
--- a/client/rhel/rhn-client-tools/src/bin/rhnreg_ks.py
+++ b/client/rhel/rhn-client-tools/src/bin/rhnreg_ks.py
@@ -24,7 +24,12 @@ import sys
import os
import gettext
-_ = gettext.gettext
+
+# bnc#664915 / red hat bugzilla #683546 rhnreg_ks --help failed if LANG = de_DE.UTF-8
+#_ = gettext.gettext
+t = gettext.translation('rhn-client-tools', '/usr/share/locale/', fallback=True)
+def _(str):
+ return unicode(t.gettext(str), 'UTF-8')
sys.path.append("/usr/share/rhn/")
--
1.6.4.2
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
