Hey,
You are using checkstyle 4.1 it seems, while we use version 4.3.
Our version seems to need the lib directory jars to be contained
in the classpath for finding exception classes the are referenced
by @throws clauses. Otherwise we get a lot of these errors:
./code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java:0: Got an
exception -
java.lang.RuntimeException: Unable to get class information for @throws tag
'HibernateException'.
Also 4.3 doesn't like the @{inherit-doc} for methods that are not
actually overrides, like the constructor in ScapActionDetails.java:
./code/src/com/redhat/rhn/domain/action/scap/ScapActionDetails.java:33:5:
Invalid use of the
{@inheritDoc} tag.
Just in case you are planning to upgrade or want to fix anyways.
Regards,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From 0bcacfc4bbc032c17263198f5bc8dde4ec000aef Mon Sep 17 00:00:00 2001
From: Johannes Renner <jren...@suse.de>
Date: Fri, 30 Mar 2012 10:26:25 +0200
Subject: [PATCH] Add lib directory to checkstyle classpath
---
java/spacewalk-java.spec | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/java/spacewalk-java.spec b/java/spacewalk-java.spec
index 2fc7361..7ae7c45 100644
--- a/java/spacewalk-java.spec
+++ b/java/spacewalk-java.spec
@@ -327,7 +327,7 @@ ant -Dprefix=$RPM_BUILD_ROOT init-install compile
%if 0%{?run_checkstyle}
echo "Running checkstyle on java main sources"
-export CLASSPATH="build/classes"
+export CLASSPATH="build/classes:build/build-lib/*"
export BASE_OPTIONS="-Djavadoc.method.scope=public \
-Djavadoc.type.scope=package \
-Djavadoc.var.scope=package \
--
1.7.7
>From 2b57a83dd3346dcaeff55586cacc13e5728e3d38 Mon Sep 17 00:00:00 2001
From: Johannes Renner <jren...@suse.de>
Date: Thu, 29 Mar 2012 16:10:13 +0200
Subject: [PATCH] Fix checkstyle error (invalid use of the {@inheritDoc} tag)
---
.../rhn/domain/action/scap/ScapActionDetails.java | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/domain/action/scap/ScapActionDetails.java b/java/code/src/com/redhat/rhn/domain/action/scap/ScapActionDetails.java
index 7c34c49..885da51 100644
--- a/java/code/src/com/redhat/rhn/domain/action/scap/ScapActionDetails.java
+++ b/java/code/src/com/redhat/rhn/domain/action/scap/ScapActionDetails.java
@@ -28,7 +28,7 @@ public class ScapActionDetails extends ActionChild {
private byte[] parameters;
/**
- * {@inheritDoc}
+ * Default constructor.
*/
public ScapActionDetails() {
super();
--
1.7.7
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
