On 03/07/2012 11:57 AM, Johannes Renner wrote: > On 03/06/2012 05:42 PM, Johannes Renner wrote: >> Hey, >> >> I want to propose a change concerning the names of cloned errata. >> Currently, names of cloned errata are generated like this: >> >> String clonedAdvisoryName = "CL" + published.getAdvisoryName().substring(3); >> String clonedAdvisory = "CL" + published.getAdvisory().substring(3); >> >> The reason for doing it like this might have been a small sized field in the >> database, but AFAIK we already upstreamed a patch to enlarge the respective >> field. Since cloned errata currently end up with rather strange names, I >> would like to propose to do the naming like this instead: >> >> String clonedAdvisoryName = "CL-" + published.getAdvisoryName(); >> String clonedAdvisory = "CL-" + published.getAdvisory(); >> >> Even the classification used for the Red Hat patches (E, S and B) gets lost >> when removing the first 3 characters, since names start with RH(E|S|B). So >> please tell me if I am missing any reason to keep the old naming scheme. >> >> Attached please find my proposed patch for spacewalk master. > > Of course this algorithm is duplicated in the perl parts of Spacewalk ;-) > Patch is attached.
Just reactivating/raising this thread on the list since there is no comments yet, and I'm curious if you will accept the proposed changes or not. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
