Hi there Silvio,
----- Original Message -----
> Hi,
> I noticed that the make-eclipse-project Ant task in build.xml depends
> on link-jars, which as far as I understand should not be needed. This
> could result in errors when a developer wants to produce the Eclipse
> project files even if he/she doesn't have all dependencies set up
> correctly (eg. because they are available, but in other locations).
>
> I attached a simple patch that removes the dependency.
Good idea! However, I'd like to not change the existing default behavior.
What do think about the attached patch instead?
Thanks,
Grant
diff --git a/java/build.xml b/java/build.xml
index 1431394..6077bb6 100644
--- a/java/build.xml
+++ b/java/build.xml
@@ -61,8 +61,8 @@
</copy>
</target>
- <!-- Generates Eclipse classpath -->
- <target name="gen-eclipse" depends="link-jars"
+ <!-- Generates Eclipse .classpath -->
+ <target name="gen-eclipse-base" depends="resolve"
description = "Generates eclipse .classpath file">
<exec executable="${basedir}/scripts/gen-eclipse.py"
output="${basedir}/.classpath" >
@@ -70,6 +70,11 @@
</exec>
</target>
+ <!-- Generates Eclipse classpath after setting up dependent jars -->
+ <target name="gen-eclipse" depends="gen-eclipse-base, link-jars"
+ description = "Generates eclipse .classpath file after linking jars">
+ </target>
+
<target name="missingstrings"
description="prints out a report with untranslated strings.">
<mkdir dir="${report.dir}" />
@@ -929,6 +934,11 @@ delete from rhnChannel where label like 'ChannelLabel%';
</delete>
</target>
+ <!--
+ Set up Eclipse project files
+ NOTE: If this fails due to missing-jars, and you want to continue,
+ then execute "ant gen-eclipse-base" and retry
+ -->
<target name="make-eclipse-project" depends = "gen-eclipse"
description="Configures this checkout as an eclipse project.">
<copy toDir="${rhn-home}" overwrite="false">
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
