Thanks for your patchs, I have applied/pushed them to the master. -- Matej Kollar Satellite Engineering, Red Hat
----- Original Message ----- > From: "Silvio Moioli" <smoi...@suse.de> > To: spacewalk-devel@redhat.com > Sent: Tuesday, January 21, 2014 6:19:49 PM > Subject: Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to > Java > > On 01/21/2014 01:26 PM, Matej Kollar wrote: > > * "$Rev$" is legacy of our old versioning system (cvs) and has no use > > now that we use git (and we would not like to see it in new code). > > Just to have everyone informed: I used those tags because they were > required by checkstyle_eclipse.xml. Matej will fix that configuration > file, meanwhile I fixed the patch. > > By the way I also fixed my review-pending branches with these commits: > > e9ac621 -> master-pxe-default-image-no-powermanagement > 9e04ed5 -> master-power-management-ssm > > > * Preferred space indentation for `.jsp` files is 2 spaces. > > As discussed, since there is no current standard in Spacewalk and the > Oracle code conventions for JSP is four spaces[1], we will stick with > four. Of course we can revert the decision later if a decision is taken. > > > * Use of `property="dispatch"` for submit button isn't needed > > when the only thing you actually check is `isSubmitted(form)`. [...] > > Agreed, fixed. > > > * Confirm button -- I would prefer "Reboot system" that was used on > > `.pxt` page.. > > Fixed. > > > * Using "sid": [...] one "sid" is enough. > > Okay! :-) > > Thanks for your review and thorough explanations. > > Regards > > [1] > http://www.oracle.com/technetwork/articles/javase/code-convention-138726.html > -- > Silvio Moioli > SUSE LINUX Products GmbH > Maxfeldstraße 5, 90409 Nürnberg Germany > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
