> On Sun, Jun 5, 2011 at 5:49 AM, Geert Uytterhoeven <ge...@linux-m68k.org> > wrote: >>>> Though the spi_ prefix seems redundant considering the files are in >>>> 'spi' directory. >>>> Just a thought, no objection. >>> >>> When looking at the list of loaded modules (e.g. in an Oops message), the >>> name >>> "spi_xilinx" is much more meaningful than just "xilinx", for example. >> >> Plus, when dropping the prefix, spi_xilinx.ko and gpio-xilinx.ko >> become the same... As I said, the modules could still be made spi_xilinx.ko from drivers/spi/xilinx.c and gpio_xilinx.ko from drivers/gpio/xilinx.c
On Mon, Jun 6, 2011 at 2:25 AM, Grant Likely <grant.lik...@secretlab.ca> wrote: >> Perhaps we could get Makefile to build modules with spi_ prefix. Just >> like USB gadgets do ? > I don't think it's worth mucking about with <module_name>-y := > filename.o when the filename can just be made the same as the module > name. Well, the solution was for discarding the 'redundant' prefix and yet have device specific module names. Not just for the sake of it. Anyways, I don't wanna be bitchy about it. I can buy at face value from a maintainer. I am ok with the proposed naming. Cheers! -j ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
