On Wed, 2010-04-07 at 17:50 +0200, Gerd Hoffmann wrote: > Hi, > > I'm busy fixing up the libspice-server API and preparing patches for > upstream qemu. The bits start to become usable now, so I've prepared > git trees for you to checkout. > > spice bits: > http://cgit.freedesktop.org/~kraxel/spice/log/?h=api.v2
I like this a lot, some comments: channel security cleanup: + for (i = 0; i < sizeof(names)/sizeof(names[0]); i++) { Can use SPICE_N_ELEMENTS(names) here Also, this is a change in behavior, SPICE_CHANNEL_NAME_ALL used to set *all* channels to the new value, but this only changes the default (i.e. whats used for channels that don't have a specific security set). This is not necessarily a problem, but needs checking with the qemu side so that it handles this correctly. shlib major: - -version-number $(SPICE_LT_VERSION) \ + -version-number 1:0:0 \ This is not right. We should change configure.ac to have the right libtool version style for SPICE_LT_VERSION, not hardcode it in the Makefile. MouseInterface: redesign: - void (*moution)(MouseInterface* mouse, int dx, int dy, int dz, + void (*moution)(SpiceMouseInstance *sin, int dx, int dy, int dz, uint32_t buttons_state); Its 'motion', please fix it while we can. > qemu bits: > http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/spice.v2 > > You also need a recent spice-protocol checkout for both and the usual > spice build dependencies. This is for unstable, so you need the > unstable guest drivers from the www.spice-space.org download section. I can't really comment to much on this, since i don't know the qemu code much, but this looks pretty nice and clean to me. Does it work with the recent multi-surface code that izik commited this week? We probably want izik to review this stuff. I did notice this: + spice_proto_ver=$(pkg-config --modversion spice-protocol 2>/dev/null) + spice_server_ver=$(pkg-config --modversion spice-server 2>/dev/null) + spice_cflags=$(pkg-config --cflags spice-protocol spice-server 2>/dev/null) + spice_libs=$(pkg-config --libs spice-protocol spice-server 2>/dev/null) + + spice_cflags="-I/export/git/work/spice/server/include $spice_cflags" + spice_cflags="-L/export/git/work/spice/server/.libs $spice_cflags" + spice_cflags="$spice_cflags -L/export/git/work/slirp/release" + spice_libs="$spice_libs -lspice-server -lslirp" /export/git, eh? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson Red Hat, Inc al...@redhat.com alexander.lars...@gmail.com He's a notorious moralistic househusband haunted by an iconic dead American confidante She's a beautiful French-Canadian museum curator from beyond the grave. They fight crime! _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel