Erik Lotspeich wrote:
On 11/21/2012 07:13 AM, Christophe Fergeau wrote:
On Wed, Nov 21, 2012 at 02:59:44PM +0200, Arnon Gilboa wrote:
Christophe Fergeau wrote:
On Tue, Nov 20, 2012 at 11:34:56AM -0600, Erik Lotspeich wrote:
I was wondering if there will be a Windows 8 build for the Windows guest
tools soon. I don't have much experience with Windows development or how
to compile the source. Is this something that is fairly easy to do? Can
Cygwin be used, or is Visual Studio required?
What's wrong exactly with the current tools? The version checks that fails
I guess?
I guess so. 'll check it and patch accordingly.
Ah, I was thinking of a version check I have in spice-guest-tools.exe, not
in the agent ;)
Christophe
Correct. The EXE says "unknown windows version".
It seems like Windows 7 drivers/apps generally work on Windows 8 so
maybe this is the only issue.
Regards
Erik
Patched,
Arnon
>From ed1fe65b8409c6d336b4cc46cfeb2e3a4152b56a Mon Sep 17 00:00:00 2001
From: Arnon Gilboa <agil...@redhat.com>
Date: Thu, 22 Nov 2012 13:15:02 +0200
Subject: [PATCH] vdservice: support Windows 8 & Server 2012
vdagent was ok, but vdservice required adding these to the version check.
Both are handled as the rest of the Win7 class.
Tested on Win8x64.
---
vdservice/vdservice.cpp | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
index 8f12317..b64602b 100644
--- a/vdservice/vdservice.cpp
+++ b/vdservice/vdservice.cpp
@@ -121,7 +121,7 @@ VDService* VDService::get()
enum SystemVersion {
SYS_VER_UNSUPPORTED,
SYS_VER_WIN_XP_CLASS, // also Server 2003/R2
- SYS_VER_WIN_7_CLASS, // also Server 2008/R2 & Vista
+ SYS_VER_WIN_7_CLASS, // also Windows 8, Server 2012, Server 2008/R2 & Vista
};
int supported_system_version()
@@ -136,7 +136,7 @@ int supported_system_version()
}
if (osvi.dwMajorVersion == 5 && (osvi.dwMinorVersion == 1 || osvi.dwMinorVersion == 2)) {
return SYS_VER_WIN_XP_CLASS;
- } else if (osvi.dwMajorVersion == 6 && (osvi.dwMinorVersion == 0 || osvi.dwMinorVersion == 1)) {
+ } else if (osvi.dwMajorVersion == 6 && (osvi.dwMinorVersion >= 0 || osvi.dwMinorVersion <= 2)) {
return SYS_VER_WIN_7_CLASS;
}
return 0;
--
1.7.4.1
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
