On Fri, 2007-04-13 at 14:29 +1000, Robert Collins wrote:
> On Thu, 2007-04-12 at 22:02 -0600, Alex Rousskov wrote:
> > 
> > That is good, but I do not think we should require it. Cppunit is a
> > developer tool. "Make check" is a user-level reassurance that the
> > package was built correctly.
...
> I think you should decide to either:
>  - keep cppunit in the source tree
> or
>  - have make check fail when its not installed.

I caught up with Alex to discuss this on IRC, we didn't come to much in
the way of agreement. One thing we did agree on was:

14:56 < lifeless> I was trying to say that 'removing cppunit's source
      from the squid codebase' != changing squid to have make check not
      error when cppunit is not available.
14:57  * alexx agrees that removing and changing "make check" are
      different steps/issues.

So I'd like to ask that the change made to remove cppunit's source from
the code base *NOT* change the current behaviour that 'make check'
*depends* on libcppunit being available.

That will let the current bug be closed and is apparently
non-contentious.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to