On 11/12/2011 04:44 PM, Amos Jeffries wrote: > On 13/11/2011 3:05 a.m., Tsantilas Christos wrote: >> This is a patch for the bug 2619. Please see in squid bugzilla for >> problem description and discussions: >> http://bugs.squid-cache.org/show_bug.cgi?id=2619 >> >> This patch is similar to the original patch developed my Martin Huter >> plus some code to solve the same problem in reqmod ICAP requests and >> some other minor fixes. >> > > Seems okay to me. I like how its being agnostic now about which of the > adapted/origin sources is being kicked.
+1 from me. Martin Huter, Christos, and I probably spent close to 100 hours together on this old problem! I am happy with the final patch shape. I regret we have to use the seemingly broken StoreEntry::bytesWanted() interface, but Christos marked resulting problems with XXXs and fixing those should not be in this project scope. Cheers, Alex.
