Yes it looks like a typo.

Markus

"Pavel Timofeev" wrote in message news:CAAoTqftnGm9+iUxxnSCyRcRhKAQyJ-dkWLqQqR3YaL=wawe...@mail.gmail.com...

Thanks!

I think I've noticed a typo in squid 3.4.7

# diff -u helpers/external_acl/kerberos_ldap_group/support_ldap.cc.orig
helpers/external_acl/kerberos_ldap_group/support_ldap.cc
--- helpers/external_acl/kerberos_ldap_group/support_ldap.cc.orig
2014-08-27 21:37:01.000000000 +0400
+++ helpers/external_acl/kerberos_ldap_group/support_ldap.cc
2014-08-27 21:37:15.000000000 +0400
@@ -811,7 +811,7 @@
#endif
    }

-    if (kc && (!margs->lurl || !margs->luser | !margs->lpass)) {
+    if (kc && (!margs->lurl || !margs->luser || !margs->lpass)) {
        /*
         * If Kerberos fails and no url given exit here
         */

True?

2014-08-27 18:20 GMT+04:00 Amos Jeffries <squ...@treenet.co.nz>:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 26/08/2014 7:44 a.m., Markus Moeller wrote:
Hi Pavel,

Can you remove line 263 from support_krb5.cc and recompile ?  It is
fixed in the trunk for 3.5.

The line is safe_free(principal_name);

Regards Markus


For the record, this fix is now in 3.4.7.

Amos

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJT/elDAAoJELJo5wb/XPRjsk0H/irbDYvwbf8Asg/XWuxX1vK8
w0aiTACKtr/G3le2qpKz5eZLtG+6J5fznujN04wFDBdOmwfr4j+MWV8IcYO3Ij/y
SfdsGIu7oRljQrBUMWop5Leyxg3kqYcQc+8316mlAgr4SdLeQTFN+8H+jpv2Rdv3
Ftxaf0/eVnnujnwnnU5UijVXJ5pur/IMeXv+raByCzFdRVJm4ooHxJYMwe5vYzgI
ParSG9zlslZh3xR9Ae75Joo3R9S5PN6qnwiBTw4e73NP9m3aiDOyYHIOXIWEf2/Y
BD4hlTm7j9sJWumyBh0b0VD2D05cYV7eVlZzOkqoBWsiTkBNMf4z5kEpmvenjt0=
=RLho
-----END PGP SIGNATURE-----


Reply via email to