On Thu, Sep 01, 2011 at 11:38:32AM -0400, Stephen Gallagher wrote: > On Wed, 2011-08-31 at 21:32 +0200, Sumit Bose wrote: > > Works great. I found two minor issues: > > > > > diff --git a/Makefile.am b/Makefile.am > > > index > > > 4e2e26bae9ba9b388998d3c1af84f8a7aa2e51ed..1d381612eb1c43c4494331cb205d0d88a5f3a477 > > > 100644 > > > --- a/Makefile.am > > > +++ b/Makefile.am > > > @@ -34,6 +34,7 @@ systemdunitdir = @systemdunitdir@ > > > logpath = @logpath@ > > > pubconfpath = @pubconfpath@ > > > pkgconfigdir = $(libdir)/pkgconfig > > > +krb5rcachedir = @krb5rcachedir@ > > > > > > AM_CFLAGS = > > > if WANT_AUX_INFO > > > @@ -1141,6 +1142,7 @@ install-data-hook: > > > rm $(DESTDIR)/$(nsslibdir)/libnss_sss.so.2 \ > > > $(DESTDIR)/$(nsslibdir)/libnss_sss.so > > > mv $(DESTDIR)/$(nsslibdir)/libnss_sss.so.2.0.0 > > > $(DESTDIR)/$(nsslibdir)/libnss_sss.so.2 > > > + mkdir -p $(krb5rcachedir) > > > > $(DESTDIR)/ is missing and mkdir shouldn't be called if $(krb5rcachedir) > > is __LIBKRB5_DEFAULTS__ > > > > > > > > uninstall-hook: > > > if [ -f $(abs_builddir)/src/config/.files ]; then \ > > > > > diff --git a/src/confdb/confdb.h b/src/confdb/confdb.h > > > index > > > 5e50991f3014019b0c8fd065f4728827d959f06b..e982d17983eb68b3cde4d58b4289a447c723f90e > > > 100644 > > > --- a/src/confdb/confdb.h > > > +++ b/src/confdb/confdb.h > > > @@ -63,6 +63,7 @@ > > > #define CONFDB_MONITOR_NAME_REGEX "re_expression" > > > #define CONFDB_MONITOR_FULL_NAME_FORMAT "full_name_format" > > > #define CONFDB_MONITOR_TRY_INOTIFY "try_inotify" > > > +#define CONFDB_MONITOR_KRB5_RCACHEDIR "krb5_rcachedir" > > > > _ missing > > > > > > > > /* NSS */ > > > #define CONFDB_NSS_CONF_ENTRY "config/nss" > > Thank you for your diligence, Sumit. New patch attached.
ACK bye, Sumit _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
