On Thu, Apr 03, 2014 at 09:45:46AM +0200, Sumit Bose wrote:
> On Wed, Apr 02, 2014 at 10:29:15PM +0200, Jakub Hrozek wrote:
> > Hi,
> >
> > please see the attached patch that fixes a use-after-free bug in the
> > SELinux provider.
> >
> > Pair-Programmed-With: lsleb...@redhat.com
>
> The patch solves the issue, but I think the issue was there in the first
> place, because the 'order' string is somewhat hidden. I would suggest to
> use a struct like
>
> struct order_ctx {
> const char *order;
> char **order_array;
> size_t order_count;
> };
>
> It might be a bit overkill for this small usage, but I think it makes
> the intention and the relation between order and order_array more clear.
>
> bye,
> Sumit
Would you accept this small patch for 1.11 and your proposed (and
better, I agree) change for master?
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
