Hi!
> > > > Well, but if some data structures are different than the tmpfs driver
> > > > thinks
> > > > they are, the kernel could oops/panic at umount, couldn't it?
> > >
> > > Yes, it could, but they won't be. After a successful resume the tmpfs
> > > will
> > > be in the same state as before the suspend, won't it?
> >
> > Ah, ok. That's the detail that i forgot.
> >
> > > [The problem with disk filesystems is they tend to preserve data across
> > > the
> > > suspend-resume cycle. ;-)]
> >
> > Yes, which is of course a different issue.
> >
> > No objections from my side, then :-)
>
> Thanks.
>
> Appended is the version of the patch I'd like to apply if there are no
> objections.
>
> Please note this patch will be _necessary_ for s2disk/s2both to work if the
> kernel starts to carry out the freezeing of bdevs during the suspend (not
> implemented yet, but coming).
Looks good to me...
> @@ -66,7 +67,9 @@ static char password[PASS_SIZE];
> #define encrypt 0
> #define key_name NULL
> #endif
> +#ifdef CONFIG_BOTH
> static char s2ram;
> +#endif
I'd say that unused variable is less evil than ifdef...
> @@ -1221,6 +1226,10 @@ int main(int argc, char *argv[])
> }
> #endif
>
> + chroot_path = malloc(MAX_STR_LEN);
> + if (!chroot_path)
> + goto Free;
> +
Can we just allocate it statically?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
