Hi, i had a problem on one machine, where a missing platform_finish in the atomic_snapshot() error-path leads to an endless-blinking suspend LED.
This was detected as a fallout of https://bugzilla.novell.com/show_bug.cgi?id=218377 Funny thing is, that it does not help on that machine, the LED blinks until the power is off, not until platform_finish :-( Index: suspend.c =================================================================== RCS file: /cvsroot/suspend/suspend/suspend.c,v retrieving revision 1.63 diff -u -p -r1.63 suspend.c --- suspend.c 2 Nov 2006 22:05:53 -0000 1.63 +++ suspend.c 6 Nov 2006 15:54:46 -0000 @@ -826,6 +826,11 @@ int suspend_system(int snapshot_fd, int } } while (--attempts); + /* we only get here when we failed to suspend. + Remember, suspend_shutdown() never returns! */ + if (use_platform_suspend) + platform_finish(snapshot_fd); + Unfreeze: unfreeze(snapshot_fd); return error; -- Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
