On Monday, 27 November 2006 22:39, Stefan Seyfried wrote:
> On Mon, Nov 27, 2006 at 10:37:08AM -0500, Daniel Drake wrote:
> > Hi,
> >
> > I'm working on adding suspend to Gentoo Linux. Here is a patch which
> > allows more of the build to be customised by the build system, without
> > modifying any of the defaults.
>
> I have no objections and am not really a Makefile specialist, but is
> this necessary?
> I am building our package with
>
> make ARCH=%_arch \
> SUSPEND_DIR=/usr/sbin \
> CFLAGS="$RPM_OPT_FLAGS -Iliblzf-1.6 -Lliblzf-1.6" \
> CONFIG_COMPRESS=yes \
> CONFIG_ENCRYPT=yes \
> CONFIG_UDEV=yes
>
> and it seems to work fine. It looks like i really have to read up on
> the different ways of variable assignment in Makefiles somewhen :-)
>
> > I also enabled CONFIG_UDEV by default as this seems sensible.
>
> Agreed
>
> > -CC_FLAGS=-I/usr/local/include
> > -LD_FLAGS=-L/usr/local/lib
> > +CC_FLAGS?=-I/usr/local/include
> > +LD_FLAGS?=-L/usr/local/lib
>
> We could even drop this /usr/local/ stuff, since the compiler / linker
> should have it in its default search path anyway, or are there systems
> out there where this is not true?
Eg. where root has changed that?
--
You never change things by fighting the existing reality.
R. Buckminster Fuller
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
