On Thursday 12 August 2010 12:37 pm, m...@freebsd.org wrote:
> On Thu, Aug 12, 2010 at 9:13 AM, Jung-uk Kim <j...@freebsd.org>
wrote:
> > Author: jkim
> > Date: Thu Aug 12 16:13:24 2010
> > New Revision: 211228
> > URL: http://svn.freebsd.org/changeset/base/211228
> >
> > Log:
> > �Provide description for 'machdep.disable_rtc_set' sysctl.
> > �Clean up style(9) �nits. �Remove a redundant return statement
> > and an unnecessary variable.
--- >8 SNIP!!! --- >8 ---
> While the device_printf() is a single statement, it spans multiple
> lines. It seems in this instance that clarity is preserved better
> by using braces even though not required by C.
>
> Quoting style(9):
>
> Space after keywords (if, while, for, return, switch). No braces
> ('{' and '}') are used for control statements with zero or only a
> single statement unless that statement is more than a single line
> in which case they are permitted.
>
> So both styles are accepted, and I would think that changing this
> is needless code churn.
Some times it is very hard to read code when if statements contain
excessive braces and 'else' statements although is permitted by
style(9). It was one of those cases. Please note a 'else' block was
also removed from there.
Besides, I don't think it is revert worthy, either. ;-)
Thanks,
Jung-uk Kim
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
